54649[WIP][!!!][TASK] Remove sys_language_uid=-1 support
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 42
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php+0 −7
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseSystemLanguageRows.php+0 −9
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseSystemLanguageRowsTest.php+0 −30
- typo3/sysext/core/Configuration/TCA/sys_category.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_collection.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_file_metadata.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/createContentForLanguageAll.csvdeleted+0 −10
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+0 −15
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+0 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_offer.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_price.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_offer.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_price.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel_offer_rel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_offer.php+0 −1
Show 22 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_price.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel_offer_rel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_offer.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_offer.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_price.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel_rel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Configuration/TCA/tx_testdatahandler_element.php+0 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+3 −4
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_blog.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_post.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+3 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+8 −8
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −2
- typo3/sysext/frontend/Classes/Page/PageRepository.php+59 −63
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+1 −7
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+0 −1
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+1 −8
Review log 813
-
Benni Mack uploaded patch set 1 11/15/17, 11:57
-
Oliver Hader updated the commit message in patch set 2 11/15/17, 12:00
-
Mathias Brodala commented on patch set 1 11/15/17, 12:00
This is the most crucial point. How do we want to handle this in the future? Currently one can e.g. insert a plugin for all languages and thus ensure that any changed setting in the default language immediately affects all translations. With regular translations you must ensure this manually. -
Benni Mack commented on patch set 1 11/15/17, 12:03
Reply
yes. but in real life (at least in our projects) we always had to create the page translation where this -1 plugin sits on, manually as well. I'd opt for a "create page translation and translate all items on that page" option in the BE. -
Oliver Hader updated the commit message in patch set 3 11/15/17, 12:03
-
TYPO3com voted on patch set 1 V -1 11/15/17, 12:09 Completed build in 11m 41s on Wed, 15 Nov, 01:09 PM Test Summary: 50 of 57129 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16377
-
TYPO3com voted on patch set 2 V -1 11/15/17, 12:12 Completed build in 11m 52s on Wed, 15 Nov, 01:12 PM Test Summary: 50 of 57129 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16378
-
TYPO3com voted on patch set 3 V -1 11/15/17, 12:15 Completed build in 11m 41s on Wed, 15 Nov, 01:15 PM Test Summary: 50 of 57129 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16379
-
Benni Mack uploaded patch set 4 11/15/17, 12:33
-
Benni Mack uploaded patch set 5 11/15/17, 12:37
-
TYPO3com voted on patch set 4 V -1 11/15/17, 12:41 Completed build in 08m 53s on Wed, 15 Nov, 01:41 PM Test Summary: 18 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16380
-
TYPO3com voted on patch set 5 V +1 11/15/17, 12:47 Completed build in 10m 05s on Wed, 15 Nov, 01:47 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16381
-
Benni Mack abandoned the change 12/06/17, 10:09
not part of v9, will abandon this change for now