Review main Abandoned Breaking

54649[WIP][!!!][TASK] Remove sys_language_uid=-1 support

Benni Mack CR 0 V 0 Hard +78 −205 updated 12/06/17, 10:09

Commit message

The "All Languages" functionality is removed for TYPO3, thus, not evaluated
nor selectable in TYPO3 Frontend or Backend.

Instead, an upgrade wizard ensures that the the existing "-1" records
are migrated towards "0" and localized records are translated.

This solves a couple of issues:
- Paves the way for going further with "non-overlaid" record fetching in FE
- Current issues with free/connected mode in page module
- Inconsistent query handling
- Permission settings for editors trying to edit "their" language

This also means that:
- If a new sys_language gets added, the previous "-1" records must be translated
manually
- An editor limit to a language/translation could see but also disable/enable this
element because it is in "his/her" language.

@TODO
- upgrade wizard: move all lang=-1 records to default language
  & localized (clone) into according sys_language.uid languages
- consider nested IRRE structures when localizing, e.g. introduce aggregate resolver
- TCA migration for language field (sys_language_uid) to remove -1 item
- TCA migration for foreign_table_where if only sys_language_uid=-1 is requested

Review

  • Code review CR 0
  • Verified V 0

Files 42

Show 22 more files

Review log 813

  1. Benni Mack uploaded patch set 1 11/15/17, 11:57

  2. Oliver Hader updated the commit message in patch set 2 11/15/17, 12:00

  3. Mathias Brodala commented on patch set 1 11/15/17, 12:00

    This is the most crucial point. How do we want to handle this in the future? Currently one can e.g. insert a plugin for all languages and thus ensure that any changed setting in the default language immediately affects all translations. With regular translations you must ensure this manually.
  4. Benni Mack commented on patch set 1 11/15/17, 12:03

    Reply

    yes. but in real life (at least in our projects) we always had to create the page translation where this -1 plugin sits on, manually as well. I'd opt for a "create page translation and translate all items on that page" option in the BE.
  5. Oliver Hader updated the commit message in patch set 3 11/15/17, 12:03

  6. TYPO3com voted on patch set 1 V -1 11/15/17, 12:09 Completed build in 11m 41s on Wed, 15 Nov, 01:09 PM Test Summary: 50 of 57129 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16377

  7. TYPO3com voted on patch set 2 V -1 11/15/17, 12:12 Completed build in 11m 52s on Wed, 15 Nov, 01:12 PM Test Summary: 50 of 57129 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16378

  8. TYPO3com voted on patch set 3 V -1 11/15/17, 12:15 Completed build in 11m 41s on Wed, 15 Nov, 01:15 PM Test Summary: 50 of 57129 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16379

  9. Benni Mack uploaded patch set 4 11/15/17, 12:33

  10. Benni Mack uploaded patch set 5 11/15/17, 12:37

  11. TYPO3com voted on patch set 4 V -1 11/15/17, 12:41 Completed build in 08m 53s on Wed, 15 Nov, 01:41 PM Test Summary: 18 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16380

  12. TYPO3com voted on patch set 5 V +1 11/15/17, 12:47 Completed build in 10m 05s on Wed, 15 Nov, 01:47 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16381

  13. Benni Mack abandoned the change 12/06/17, 10:09

    not part of v9, will abandon this change for now