Review TYPO3_8-7 Merged

54650[BUGFIX] Fix allowLanguageSynchronization on pages_language_overlay

Oliver Hader CR +2 V +2 Easy +9 −4 updated 11/16/17, 08:54

Commit message

In case a TCA field uses allowLanguageSynchronization (or
l10n_mode=exclude) for table pages_language_overlay, dependencies
(localizations of the initial record) are processed that point to
the according pages_language_overlay. However pages_language_overlay
records cannot be localized further, they always depend on a single
pages record which is the record of the default language.

In case the backend is used as non-admin user that has a language
restriction ("Limit to languages" in backend groups/users settings),
an error message is shown:

    [newlog()] recordEditAccessInternals() check failed.
    [ERROR: Language was not allowed.]

In TYPO3 v8, all pages_language_overlay records are selected which match
the condition pages_language_overlay.pid = pages_language_overlay.uid
(pid is used as transOrigPointerField). In TYPO3 v9 this changed since
pages_language_overlay has been migrated into pages having a distinct
transOrigPointerField in l10n_parent.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Oliver Hader uploaded patch set 1 11/15/17, 12:45

  2. Susi Moog voted on patch set 1 CR +1 11/15/17, 12:49

  3. TYPO3com voted on patch set 1 V +1 11/15/17, 12:59 Completed build in 13m 12s on Wed, 15 Nov, 01:59 PM Test Summary: 57605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1220

  4. Benni Mack updated the commit message in patch set 2 11/15/17, 13:54

  5. TYPO3com voted on patch set 2 V +1 11/15/17, 14:02 Completed build in 07m 34s on Wed, 15 Nov, 03:02 PM Test Summary: 57605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1221

  6. Susi Moog voted on patch set 2 CR +1 V +1 11/15/17, 15:33

  7. Frank Nägler voted on patch set 2 CR +2 V +2 11/16/17, 08:54

  8. Gerrit merged patch set 2 11/16/17, 08:54