Review main Merged

54655[BUGFIX] Avoid invalid references in DataMapProcessor

Oliver Hader CR +2 V +2 Normal +103 −6 updated 11/16/17, 17:22

Commit message

If DataMapProcessor is called with a non-reference id, e.g.
zero (0), this submission is considered as a reference. Since
there is no database record having UID 0, the synchronization
process fails with the following exeception:

	#1486233164: Child record was not processed

To solve this behavior, invalid references (empty/zero) are
not considered anymore to compare references. Besides that,
values for localized records that are configured to be
synchronized are sanitized correctly now.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Susi Moog +1
  • Verified V +2
    • Oliver Hader +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1116

  1. Oliver Hader uploaded patch set 1 11/15/17, 15:08

  2. TYPO3com voted on patch set 1 V +1 11/15/17, 15:17 Completed build in 09m 06s on Wed, 15 Nov, 04:17 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16391

  3. Oliver Hader uploaded patch set 2 11/15/17, 20:28

  4. Oliver Hader updated the commit message in patch set 3 11/15/17, 20:29

  5. TYPO3com voted on patch set 2 V +1 11/15/17, 20:39 Completed build in 10m 52s on Wed, 15 Nov, 09:39 PM Test Summary: 56772 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16399

  6. TYPO3com voted on patch set 3 V +1 11/15/17, 20:39 Completed build in 10m 40s on Wed, 15 Nov, 09:39 PM Test Summary: 56772 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16400

  7. Oliver Hader commented on patch set 3 CR -1 11/16/17, 11:45

    Investigating
  8. Oliver Hader uploaded patch set 4 11/16/17, 13:46

  9. TYPO3com voted on patch set 4 V -1 11/16/17, 13:55 Completed build in 09m 47s on Thu, 16 Nov, 02:55 PM Test Summary: 2 of 57133 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16421

  10. Oliver Hader uploaded patch set 5 11/16/17, 14:14

  11. TYPO3com voted on patch set 5 V +1 11/16/17, 14:26 Completed build in 12m 02s on Thu, 16 Nov, 03:26 PM Test Summary: 56774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16424

  12. Susi Moog voted on patch set 5 CR +1 11/16/17, 15:08

  13. Susi Moog voted on patch set 5 V +1 11/16/17, 15:10

  14. Benni Mack commented on patch set 5 11/16/17, 15:44

    AbstractActionTestCase.php:552

    i'd be really cool if this would be detected / changed automatically.
  15. Oliver Hader voted on patch set 5 CR +2 V +2 11/16/17, 17:21

  16. Gerrit merged patch set 5 11/16/17, 17:22