Review TYPO3_8-7 Merged

54656[BUGFIX] Set l10n_state before synchronizing fields

Helmut Hummel CR +2 V +2 Normal +204 −42 updated 11/16/17, 20:46

Commit message

L10nModeUpdater checks whether fields in translated records are
modified, thus not synchronized with the parent record and the
new l10n_state for this field is set to "custom" in this case
or "parent" if the field is empty.

However this is done after the data is synchronized, which
leads to wrong data being written by the DataMapProcessor.

To fix this, we move setting l10n_state upwards in the code,
so that relations and fields from translated records can be
updated correctly.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1321

  1. Helmut Hummel uploaded patch set 1 11/15/17, 17:12

  2. Oliver Hader uploaded patch set 2 11/15/17, 17:19

  3. TYPO3com voted on patch set 1 V +1 11/15/17, 17:21 Completed build in 09m 28s on Wed, 15 Nov, 06:21 PM Test Summary: 57605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1222

  4. Oliver Hader updated the commit message in patch set 3 11/15/17, 17:28

  5. TYPO3com voted on patch set 2 V +1 11/15/17, 17:31 Completed build in 12m 34s on Wed, 15 Nov, 06:31 PM Test Summary: 57605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1223

  6. Helmut Hummel commented on patch set 2 11/15/17, 17:33

    L10nModeUpdater.php:160

    unrelated to this very issue here, but this early return isn't clean, as there is cleanup code (beuser/hooks) that is skipped. instead, we should invert the if and wrap it around the datahandler call
  7. Oliver Hader commented on patch set 2 11/15/17, 17:36

    L10nModeUpdater.php:160 Reply

    +1 absolutely correct
  8. TYPO3com voted on patch set 3 V +1 11/15/17, 17:37 Completed build in 08m 26s on Wed, 15 Nov, 06:37 PM Test Summary: 57605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1224

  9. Helmut Hummel uploaded patch set 4 11/15/17, 18:01

  10. TYPO3com voted on patch set 4 V +1 11/15/17, 18:16 Completed build in 15m 17s on Wed, 15 Nov, 07:16 PM Test Summary: 57605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1225

  11. Helmut Hummel uploaded patch set 5 11/15/17, 18:52

  12. TYPO3com voted on patch set 5 V +1 11/15/17, 19:02 Completed build in 10m 01s on Wed, 15 Nov, 08:02 PM Test Summary: 57605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1226

  13. Helmut Hummel uploaded patch set 6 11/15/17, 20:46

  14. TYPO3com voted on patch set 6 V +1 11/15/17, 20:57 Completed build in 10m 35s on Wed, 15 Nov, 09:57 PM Test Summary: 57605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1227

  15. Oliver Hader uploaded patch set 7 11/16/17, 18:35

  16. Helmut Hummel commented on patch set 7 11/16/17, 18:37

    L10nModeUpdater.php:99

    doesn't this distinction need to be kept for 8.7?
  17. TYPO3com voted on patch set 7 V -1 11/16/17, 18:44 Completed build in 08m 49s on Thu, 16 Nov, 07:44 PM Test Summary: 1 of 57971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1241

  18. Oliver Hader uploaded patch set 8 11/16/17, 19:59

  19. TYPO3com voted on patch set 8 V +1 11/16/17, 20:09 Completed build in 09m 41s on Thu, 16 Nov, 09:09 PM Test Summary: 57611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1242

  20. Oliver Hader voted on patch set 8 CR +2 V +2 11/16/17, 20:46

  21. Gerrit merged patch set 8 11/16/17, 20:46