54657[BUGFIX] Set l10n_state before synchronizing fields
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Susi Moog +1
-
Verified V +2
- Oliver Hader +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/install/Classes/Updates/RowUpdater/L10nModeUpdater.php1+28 −42
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/DataSet/LiveDefaultElements.csvnew+29 −0
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/DataSet/LiveDefaultPages.csvnew+6 −0
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/DataSet/recordsCanBeUpdated.csvnew+40 −0
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/L10nModeUpdaterTest.php1new+101 −0
Review log 1523
-
Helmut Hummel uploaded patch set 1 11/15/17, 17:53
-
Helmut Hummel updated the commit message in patch set 2 11/15/17, 18:00
-
TYPO3com voted on patch set 1 V +1 11/15/17, 18:04 Completed build in 11m 27s on Wed, 15 Nov, 07:04 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16395
-
TYPO3com voted on patch set 2 V +1 11/15/17, 18:11 Completed build in 10m 30s on Wed, 15 Nov, 07:11 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16396
-
Helmut Hummel uploaded patch set 3 11/15/17, 20:46
-
TYPO3com voted on patch set 3 V +1 11/15/17, 20:57 Completed build in 11m 05s on Wed, 15 Nov, 09:57 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16401
-
Stefan Neufeind commented on patch set 3 11/15/17, 21:54
Can we cover that case with a functional test maybe? -
Oliver Hader commented on patch set 3 CR -1 11/16/17, 13:50
Working on it... Probably needs https://review.typo3.org/#/c/53787/ first...L10nModeUpdater.php:153This was wrong before and needs to be fixed as well. In case the value is used either as IRRE relations or as any other relation persisted in MM-tables, this would be the reference count, e.g. "5". However if passed along, "5" is considered to be the UID of a records - which is wrong. -
Oliver Hader uploaded patch set 4 11/16/17, 17:24
-
TYPO3com voted on patch set 4 V -1 11/16/17, 17:33 Completed build in 09m 30s on Thu, 16 Nov, 06:33 PM Test Summary: 2 of 57143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16435
-
Oliver Hader uploaded patch set 5 11/16/17, 17:43
-
Oliver Hader commented on patch set 4 11/16/17, 17:44
L10nModeUpdaterTest.php:48argh, forgot to remove my local debug and test extension -
TYPO3com voted on patch set 5 V -1 11/16/17, 17:55 Completed build in 11m 54s on Thu, 16 Nov, 06:55 PM Test Summary: 1 of 57143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16436
-
Oliver Hader uploaded patch set 6 11/16/17, 18:32
-
TYPO3com voted on patch set 6 V -1 11/16/17, 18:42 Completed build in 09m 54s on Thu, 16 Nov, 07:42 PM Test Summary: 1 of 57143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16439
-
TYPO3com commented on patch set 6 11/16/17, 18:48 Completed build in 25m 25s on Thu, 16 Nov, 07:48 PM Test Summary: 1 of 57143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16439
-
Helmut Hummel commented on patch set 6 CR +1 V +1 11/16/17, 19:10
Thanks. works for me as well -
Oliver Hader uploaded patch set 7 11/16/17, 19:42
-
TYPO3com voted on patch set 7 V +1 11/16/17, 19:51 Completed build in 09m 07s on Thu, 16 Nov, 08:51 PM Test Summary: 56784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16440
-
Susi Moog voted on patch set 7 CR +1 V +1 11/16/17, 19:59
-
Oliver Hader voted on patch set 7 CR +2 V +2 11/16/17, 20:46
-
Gerrit merged patch set 7 11/16/17, 20:46
-
Helmut Hummel commented on patch set 8 11/16/17, 22:53
\o/ Thanks!