Review main Merged

54659[BUGFIX] IRRE actions should render error messages from DataHandler

Benni Mack CR +2 V +2 Easy +24 −0 updated 11/27/17, 22:12

Commit message

When IRRE actions (localize/synchronize) are triggered that result in a
DataHandler error (e.g. "Localization failed, "languageField" and
"transOrigPointerField" must be defined for the table") because of a missing
configuration, the current implementation does not evaluate DataHandler
results in the JSON response.

The change adds the same functionality as for other DataHandler calls
to evaluate the JSON response.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Jan Helke +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 11/16/17, 11:05

  2. TYPO3com voted on patch set 1 V -1 11/16/17, 11:14 Completed build in 09m 10s on Thu, 16 Nov, 12:14 PM Test Summary: 1 of 57129 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16416

  3. TYPO3com voted on patch set 1 V +1 11/16/17, 11:22 Completed build in 26m 05s on Thu, 16 Nov, 12:22 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16416

  4. Jan Helke voted on patch set 1 CR +1 V +1 11/23/17, 15:40

  5. Tymoteusz Motylewski commented on patch set 1 11/24/17, 12:29

    some instructions how to test it would be helpful
  6. Benni Mack commented on patch set 1 11/24/17, 21:44

    @tymek: try to remove the ctrl languageField section from sys_file_reference and play around with adding a new sys_file_reference to tt_content.textmedia translation via FormEngine. This does not work and there is no error currently.
  7. Tymoteusz Motylewski voted on patch set 1 CR +2 V +2 11/27/17, 22:11

  8. Gerrit merged patch set 1 11/27/17, 22:12

  9. Tymoteusz Motylewski commented on patch set 2 11/27/17, 22:12

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit b53ac63d4719b89ff574ef46cc228f61242ab80f