Review main Merged

54664[TASK] Remove hard-coded l10n_parent fields for pages

Benni Mack CR +2 V +2 Normal +104 −86 updated 11/28/17, 22:46

Commit message

Due to the change of the pages_language_overlay migration, a lot
of hard-coded "l10n_parent" and "sys_language_uid" fields for
pages have been introduced.

This should be changed into a common function in DataHandler
and the TCA option should be used instead.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 2335

Show 710 earlier messages
  1. Benni Mack uploaded patch set 1 11/16/17, 14:09

  2. Mathias Brodala commented on patch set 1 11/16/17, 14:12

    DataHandler.php:8750

    Maybe store this in a variable to do it only once?
  3. TYPO3com voted on patch set 1 V +1 11/16/17, 14:19 Completed build in 09m 41s on Thu, 16 Nov, 03:19 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16422

  4. Benni Mack uploaded patch set 2 11/16/17, 14:19

  5. Benni Mack uploaded patch set 3 11/16/17, 14:21

  6. Benni Mack commented on patch set 1 11/16/17, 14:26

    DataHandler.php:8750 Reply

    can you elaborate?
  7. TYPO3com voted on patch set 2 V +1 11/16/17, 14:29 Completed build in 10m 34s on Thu, 16 Nov, 03:29 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16425

  8. TYPO3com voted on patch set 3 V +1 11/16/17, 14:33 Completed build in 12m 11s on Thu, 16 Nov, 03:33 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16426

  9. Mathias Brodala commented on patch set 1 11/16/17, 14:34

    DataHandler.php:8750 Reply

    Something like this: $translationParent = (int)$row['l10n_parent']; if ($translationParent > 0) { return $translationParent; }
  10. Benni Mack commented on patch set 1 11/16/17, 14:35

    DataHandler.php:8750 Reply

    thanks, will fix
  1. Stefan Neufeind commented on patch set 3 CR +1 11/16/17, 14:36

    DataHandler.php:8747

    what does that comment want to say? :-)
  2. Benni Mack commented on patch set 4 11/16/17, 14:36

    Published edit on patch set 3.
  3. Benni Mack commented on patch set 4 CR -2 11/16/17, 14:37

    I think I have a few more places left outside datahandler which I'd need to adapt.
  4. TYPO3com voted on patch set 4 V +1 11/16/17, 14:49 Completed build in 12m 07s on Thu, 16 Nov, 03:49 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16428

  5. Benni Mack uploaded patch set 5 11/16/17, 14:59

  6. Benni Mack voted on patch set 4 CR 0 11/16/17, 15:00

  7. Benni Mack voted on patch set 5 CR 0 11/16/17, 15:00

  8. TYPO3com voted on patch set 5 V +1 11/16/17, 15:09 Completed build in 09m 37s on Thu, 16 Nov, 04:09 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16430

  9. Stefan Neufeind commented on patch set 5 11/17/17, 12:09

    @Benni: Just emailed you some potential lines which this patch might also need to address, a few only. Rest looks nice so far.
  10. Sebastian Hofer uploaded patch set 6 11/28/17, 11:43

  11. TYPO3com voted on patch set 6 V -1 11/28/17, 11:43 Completed build in 14s on Tue, 28 Nov, 12:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16794

  12. Sebastian Hofer uploaded patch set 7 11/28/17, 11:52

  13. TYPO3com voted on patch set 7 V -1 11/28/17, 12:03 Completed build in 10m 33s on Tue, 28 Nov, 01:03 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16795

  14. TYPO3com commented on patch set 6 11/28/17, 12:12 Completed build in 01m 52s on Tue, 28 Nov, 01:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16794

  15. TYPO3com commented on patch set 7 11/28/17, 12:12 Completed build in 30m 46s on Tue, 28 Nov, 01:12 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16795

  16. Christian Kuhn rebased onto patch set 8 11/28/17, 12:25

  17. TYPO3com voted on patch set 8 V +1 11/28/17, 12:43 Completed build in 18m 10s on Tue, 28 Nov, 01:43 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16804

  18. Sebastian Hofer uploaded patch set 9 11/28/17, 13:10

  19. TYPO3com voted on patch set 9 V +1 11/28/17, 13:20 Completed build in 09m 31s on Tue, 28 Nov, 02:20 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16817

  20. Sebastian Hofer voted on patch set 9 CR +1 11/28/17, 15:08

  21. Susi Moog uploaded patch set 10 11/28/17, 22:17

  22. Susi Moog voted on patch set 10 CR +1 V +1 11/28/17, 22:18

  23. TYPO3com voted on patch set 10 V +1 11/28/17, 22:27 Completed build in 09m 54s on Tue, 28 Nov, 11:27 PM Test Summary: 56898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16880

  24. Christian Kuhn voted on patch set 10 CR +2 V +2 11/28/17, 22:46

  25. Gerrit merged patch set 10 11/28/17, 22:46