54664[TASK] Remove hard-coded l10n_parent fields for pages
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 16
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+4 −4
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+9 −7
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabasePageLanguageOverlayRows.php+4 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+2 −2
- typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php+5 −3
- typo3/sysext/backend/Classes/View/PageLayoutView.php+9 −6
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php5+36 −40
- typo3/sysext/filelist/Classes/FileList.php+8 −3
- typo3/sysext/frontend/Classes/Page/PageRepository.php+4 −4
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+2 −2
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+7 −4
- typo3/sysext/recordlist/Classes/RecordList.php+5 −3
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+4 −2
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+2 −2
Review log 2335
Show 710 earlier messages
-
Benni Mack uploaded patch set 1 11/16/17, 14:09
-
Mathias Brodala commented on patch set 1 11/16/17, 14:12
-
TYPO3com voted on patch set 1 V +1 11/16/17, 14:19 Completed build in 09m 41s on Thu, 16 Nov, 03:19 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16422
-
Benni Mack uploaded patch set 2 11/16/17, 14:19
-
Benni Mack uploaded patch set 3 11/16/17, 14:21
-
Benni Mack commented on patch set 1 11/16/17, 14:26
DataHandler.php:8750Replycan you elaborate? -
TYPO3com voted on patch set 2 V +1 11/16/17, 14:29 Completed build in 10m 34s on Thu, 16 Nov, 03:29 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16425
-
TYPO3com voted on patch set 3 V +1 11/16/17, 14:33 Completed build in 12m 11s on Thu, 16 Nov, 03:33 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16426
-
Mathias Brodala commented on patch set 1 11/16/17, 14:34
DataHandler.php:8750ReplySomething like this: $translationParent = (int)$row['l10n_parent']; if ($translationParent > 0) { return $translationParent; } -
Benni Mack commented on patch set 1 11/16/17, 14:35
DataHandler.php:8750Replythanks, will fix
-
Stefan Neufeind commented on patch set 3 CR +1 11/16/17, 14:36
DataHandler.php:8747what does that comment want to say? :-) -
Benni Mack commented on patch set 4 11/16/17, 14:36
Published edit on patch set 3. -
Benni Mack commented on patch set 4 CR -2 11/16/17, 14:37
I think I have a few more places left outside datahandler which I'd need to adapt. -
TYPO3com voted on patch set 4 V +1 11/16/17, 14:49 Completed build in 12m 07s on Thu, 16 Nov, 03:49 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16428
-
Benni Mack uploaded patch set 5 11/16/17, 14:59
-
Benni Mack voted on patch set 4 CR 0 11/16/17, 15:00
-
Benni Mack voted on patch set 5 CR 0 11/16/17, 15:00
-
TYPO3com voted on patch set 5 V +1 11/16/17, 15:09 Completed build in 09m 37s on Thu, 16 Nov, 04:09 PM Test Summary: 56770 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16430
-
Stefan Neufeind commented on patch set 5 11/17/17, 12:09
@Benni: Just emailed you some potential lines which this patch might also need to address, a few only. Rest looks nice so far. -
Sebastian Hofer uploaded patch set 6 11/28/17, 11:43
-
TYPO3com voted on patch set 6 V -1 11/28/17, 11:43 Completed build in 14s on Tue, 28 Nov, 12:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16794
-
Sebastian Hofer uploaded patch set 7 11/28/17, 11:52
-
TYPO3com voted on patch set 7 V -1 11/28/17, 12:03 Completed build in 10m 33s on Tue, 28 Nov, 01:03 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16795
-
TYPO3com commented on patch set 6 11/28/17, 12:12 Completed build in 01m 52s on Tue, 28 Nov, 01:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16794
-
TYPO3com commented on patch set 7 11/28/17, 12:12 Completed build in 30m 46s on Tue, 28 Nov, 01:12 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16795
-
Christian Kuhn rebased onto patch set 8 11/28/17, 12:25
-
TYPO3com voted on patch set 8 V +1 11/28/17, 12:43 Completed build in 18m 10s on Tue, 28 Nov, 01:43 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16804
-
Sebastian Hofer uploaded patch set 9 11/28/17, 13:10
-
TYPO3com voted on patch set 9 V +1 11/28/17, 13:20 Completed build in 09m 31s on Tue, 28 Nov, 02:20 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16817
-
Sebastian Hofer voted on patch set 9 CR +1 11/28/17, 15:08
-
Susi Moog uploaded patch set 10 11/28/17, 22:17
-
Susi Moog voted on patch set 10 CR +1 V +1 11/28/17, 22:18
-
TYPO3com voted on patch set 10 V +1 11/28/17, 22:27 Completed build in 09m 54s on Tue, 28 Nov, 11:27 PM Test Summary: 56898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16880
-
Christian Kuhn voted on patch set 10 CR +2 V +2 11/28/17, 22:46
-
Gerrit merged patch set 10 11/28/17, 22:46
DataHandler.php:8750