Review TYPO3_8-7 Merged

54667[BUGFIX] Avoid invalid references in DataMapProcessor

Oliver Hader CR +2 V +2 Normal +101 −4 updated 11/16/17, 17:50

Commit message

If DataMapProcessor is called with a non-reference id, e.g.
zero (0), this submission is considered as a reference. Since
there is no database record having UID 0, the synchronization
process fails with the following exeception:

	#1486233164: Child record was not processed

To solve this behavior, invalid references (empty/zero) are
not considered anymore to compare references. Besides that,
values for localized records that are configured to be
synchronized are sanitized correctly now.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Oliver Hader uploaded patch set 1 11/16/17, 17:16

  2. TYPO3com voted on patch set 1 V +1 11/16/17, 17:29 Completed build in 13m 10s on Thu, 16 Nov, 06:29 PM Test Summary: 57609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1238

  3. Oliver Hader voted on patch set 1 CR +2 V +2 11/16/17, 17:50

  4. Gerrit merged patch set 1 11/16/17, 17:50