54670[TASK] Resolve translated page IDs to default language page in FE
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Mathias Brodala +1
- Susi Moog +1
-
Verified V +2
- Wouter Wolters +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2126
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 11/16/17, 21:27
-
Susi Moog voted on patch set 1 CR +1 V +1 11/16/17, 21:33
-
Benni Mack uploaded patch set 2 11/16/17, 21:37
-
TYPO3com voted on patch set 1 V +1 11/16/17, 21:39 Completed build in 12m 15s on Thu, 16 Nov, 10:39 PM Test Summary: 56790 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16451
-
TYPO3com voted on patch set 2 V +1 11/16/17, 21:48 Completed build in 10m 58s on Thu, 16 Nov, 10:48 PM Test Summary: 56790 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16453
-
Frans Saris voted on patch set 2 CR +1 11/16/17, 22:45
-
Susi Moog voted on patch set 2 CR +1 V +1 11/17/17, 05:38
-
Mathias Brodala commented on patch set 2 CR -1 11/17/17, 08:10
TypoScriptFrontendController.php:1549Same here. -
Benni Mack commented on patch set 2 11/21/17, 06:07
TypoScriptFrontendController.php:1546ReplyHa, thanks :) -
Benni Mack commented on patch set 3 11/21/17, 06:13
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 11/21/17, 06:22 Completed build in 08m 51s on Tue, 21 Nov, 07:22 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16516
-
Frans Saris voted on patch set 3 CR +1 11/21/17, 06:39
-
Andreas Kienast voted on patch set 3 CR +1 11/21/17, 08:36
-
Susi Moog voted on patch set 3 CR +1 11/24/17, 15:34
-
Mathias Brodala commented on patch set 3 11/24/17, 15:54
TypoScriptFrontendController.php:1545I guess this line can be dropped completely? -
Oliver Klee commented on patch set 3 11/24/17, 16:05
TypoScriptFrontendController.php:1546I propose we convert this to a guard clause. -
Benni Mack commented on patch set 4 11/27/17, 13:32
Published edit on patch set 3. -
Mathias Brodala commented on patch set 4 CR -1 11/27/17, 13:36
TypoScriptFrontendController.php:1545The "!" must be removed now. -
Benni Mack commented on patch set 5 11/27/17, 13:39
Published edit on patch set 4. -
TYPO3com voted on patch set 4 V +1 11/27/17, 13:45 Completed build in 13m 45s on Mon, 27 Nov, 02:45 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16670
-
TYPO3com voted on patch set 5 V +1 11/27/17, 13:49 Completed build in 10m 02s on Mon, 27 Nov, 02:49 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16673
-
Mathias Brodala voted on patch set 5 CR +1 11/27/17, 13:57
-
Susi Moog voted on patch set 5 CR +1 V +1 11/27/17, 21:46
-
Wouter Wolters voted on patch set 5 CR +1 V +1 11/27/17, 21:53
-
Wouter Wolters voted on patch set 5 CR +2 V +2 11/27/17, 21:54
-
Gerrit merged patch set 5 11/27/17, 21:54
TypoScriptFrontendController.php:1546