Review main Merged

54670[TASK] Resolve translated page IDs to default language page in FE

Benni Mack CR +2 V +2 Easy +26 −3 updated 11/27/17, 21:54

Commit message

Currently, when accessing a translated page ID via index.php?id=23,
the TypoScript cannot be resolved, as the GET parameter is no valid
page where records (e.g. sys_template etc).

In order to achieve this, the TYPO3 Frontend now resolves the $id
to the default page ID, but also sets $this->sys_language_uid and
$this->sys_language_content.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mathias Brodala +1
    • Susi Moog +1
  • Verified V +2
    • Wouter Wolters +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2126

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 11/16/17, 21:27

  1. Susi Moog voted on patch set 1 CR +1 V +1 11/16/17, 21:33

  2. Benni Mack uploaded patch set 2 11/16/17, 21:37

  3. TYPO3com voted on patch set 1 V +1 11/16/17, 21:39 Completed build in 12m 15s on Thu, 16 Nov, 10:39 PM Test Summary: 56790 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16451

  4. TYPO3com voted on patch set 2 V +1 11/16/17, 21:48 Completed build in 10m 58s on Thu, 16 Nov, 10:48 PM Test Summary: 56790 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16453

  5. Frans Saris voted on patch set 2 CR +1 11/16/17, 22:45

  6. Susi Moog voted on patch set 2 CR +1 V +1 11/17/17, 05:38

  7. Mathias Brodala commented on patch set 2 CR -1 11/17/17, 08:10

    TypoScriptFrontendController.php:1546

    Are you sure about hardcoding this again? ;-)

    TypoScriptFrontendController.php:1549

    Same here.
  8. Benni Mack commented on patch set 2 11/21/17, 06:07

    TypoScriptFrontendController.php:1546 Reply

    Ha, thanks :)
  9. Benni Mack commented on patch set 3 11/21/17, 06:13

    Published edit on patch set 2.
  10. TYPO3com voted on patch set 3 V +1 11/21/17, 06:22 Completed build in 08m 51s on Tue, 21 Nov, 07:22 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16516

  11. Frans Saris voted on patch set 3 CR +1 11/21/17, 06:39

  12. Andreas Kienast voted on patch set 3 CR +1 11/21/17, 08:36

  13. Susi Moog voted on patch set 3 CR +1 11/24/17, 15:34

  14. Mathias Brodala commented on patch set 3 11/24/17, 15:54

    TypoScriptFrontendController.php:1545

    I guess this line can be dropped completely?
  15. Oliver Klee commented on patch set 3 11/24/17, 16:05

    TypoScriptFrontendController.php:1546

    I propose we convert this to a guard clause.
  16. Benni Mack commented on patch set 4 11/27/17, 13:32

    Published edit on patch set 3.
  17. Mathias Brodala commented on patch set 4 CR -1 11/27/17, 13:36

    TypoScriptFrontendController.php:1545

    The "!" must be removed now.
  18. Benni Mack commented on patch set 5 11/27/17, 13:39

    Published edit on patch set 4.
  19. TYPO3com voted on patch set 4 V +1 11/27/17, 13:45 Completed build in 13m 45s on Mon, 27 Nov, 02:45 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16670

  20. TYPO3com voted on patch set 5 V +1 11/27/17, 13:49 Completed build in 10m 02s on Mon, 27 Nov, 02:49 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16673

  21. Mathias Brodala voted on patch set 5 CR +1 11/27/17, 13:57

  22. Susi Moog voted on patch set 5 CR +1 V +1 11/27/17, 21:46

  23. Wouter Wolters voted on patch set 5 CR +1 V +1 11/27/17, 21:53

  24. Wouter Wolters voted on patch set 5 CR +2 V +2 11/27/17, 21:54

  25. Gerrit merged patch set 5 11/27/17, 21:54