Review main Merged

54671[TASK] Use booleans where currently 1/0 are used

Stefan Neufeind CR +2 V +2 Normal +50 −50 updated 11/29/17, 16:43

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Benni Mack +2
    • Nicole Hummel +1
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 21

Review log 2127

Show 2 earlier messages
  1. Stefan Neufeind uploaded patch set 1 11/17/17, 09:27

  2. Stefan Neufeind commented on patch set 1 11/17/17, 09:28

    Searching for "1 : 0" there are other cases in the sources as well, but imho those must not be touched (since they are written as integers to the DB or similar). During review please also look at the "1 : 0"-cases that were left out here.
  1. TYPO3com voted on patch set 1 V -1 11/17/17, 09:36 Completed build in 09m 24s on Fri, 17 Nov, 10:36 AM Test Summary: 448 of 57149 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16457

  2. TYPO3com commented on patch set 1 11/20/17, 09:54 Completed build in 0h 36m 34s on Mon, 20 Nov, 10:54 AM Test Summary: 448 of 57149 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16457

  3. Andreas Kienast uploaded patch set 2 11/20/17, 19:34

  4. Tymoteusz Motylewski commented on patch set 2 CR -1 11/20/17, 19:49

    Clipboard.php:634

    shouldn't also $setRedirect be changed? Also doc comments should be updated

    PageLayoutController.php:823

    this will result in defLangbinding being string instead of boolean, won't it?

    AbstractTreeView.php:46

    we would need to set it to boolean to be consistent.
  5. TYPO3com voted on patch set 2 V -1 11/20/17, 19:54 Completed build in 19m 43s on Mon, 20 Nov, 08:54 PM Test Summary: 448 of 57161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16509

  6. Stefan Neufeind commented on patch set 2 11/20/17, 20:35

    Clipboard.php:634 Reply

    yes, sure i thought about updating the docblock to just boolean. But that would be an API-change an require a breaking-rst? Or, as long as providing an int would still work (but is legacy) would it be okay to have that as non-breaking?

    PageLayoutController.php:823 Reply

    yes, maybe a !empty() then? the varible is tagged as bool higher up in this file and used as a bool in other places it seems

    AbstractTreeView.php:46 Reply

    yes but I feared that changing that from int to bool might lead to a lot of other problems (like trying to persist that value into the DB into an int-field or so)
  7. Stefan Neufeind commented on patch set 2 CR -1 11/20/17, 20:44

    will shortly push a new version

    PageLayoutController.php:823 Reply

    I'll try to turn it into a bool for now. Please note that inside this file there is also a local variable $defLangBinding that is a multi-dimensional array. Maybe we should rename that so nobody confuses bool and array?
  8. Stefan Neufeind uploaded patch set 3 11/20/17, 20:50

  9. TYPO3com voted on patch set 3 V -1 11/20/17, 21:00 Completed build in 09m 42s on Mon, 20 Nov, 10:00 PM Test Summary: 448 of 57161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16512

  10. Nicole Hummel commented on patch set 3 11/20/17, 21:54

    PageLayoutController.php:822

    why is this one not converted to bool value?

    DataHandler.php:6477

    this can return null. IMHO cast is wrong here
  11. Stefan Neufeind commented on patch set 3 11/20/17, 23:19

    PageLayoutController.php:822 Reply

    overlooked it seems. I also changed some others to bool as well now with the next patchset.

    DataHandler.php:6477 Reply

    Hmm, it can? Yeah okay, makes sense for a hook. Then I still think we can go with isset below - and I converted it there to (bool) then so we don't return 0 or 1 accidentially from a hook
  12. Stefan Neufeind uploaded patch set 4 11/20/17, 23:19

  13. TYPO3com voted on patch set 4 V +1 11/20/17, 23:28 Completed build in 08m 59s on Tue, 21 Nov, 12:28 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16514

  14. Stefan Neufeind commented on patch set 4 11/20/17, 23:35

    Nice, acceptance-tests are green as well :-) Thanks, Nicole!
  15. Jan Helke commented on patch set 4 11/23/17, 13:17

    FrontendEditPanel.php:218

    Any reason, why you left this line unchanged?
  16. Nicole Hummel commented on patch set 4 11/23/17, 13:50

    FrontendEditPanel.php:218 Reply

    $noView is used as url argument, thus should be an int
  17. Benni Mack uploaded patch set 5 11/29/17, 15:28

  18. TYPO3com voted on patch set 5 V +1 11/29/17, 15:39 Completed build in 10m 27s on Wed, 29 Nov, 04:39 PM Test Summary: 57000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16974

  19. Markus Klein abandoned the change 11/29/17, 15:53

  20. Markus Klein restored the change 11/29/17, 15:53

  21. Nicole Hummel voted on patch set 5 CR +1 11/29/17, 15:56

  22. Benni Mack voted on patch set 5 CR +2 11/29/17, 16:19

  23. Markus Klein commented on patch set 5 CR -1 11/29/17, 16:33

    on it reviewing
  24. Markus Klein voted on patch set 5 CR +2 V +2 11/29/17, 16:43

  25. Gerrit merged patch set 5 11/29/17, 16:43