54672[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1114
-
Jigal van Hemert commented on patch set 1 11/17/17, 09:43
Cherry Picked from branch master. -
Jigal van Hemert commented on patch set 1 11/17/17, 09:46
It's only for 8.7 as master has no pages_language_overlay any more. -
TYPO3com voted on patch set 1 V +1 11/17/17, 09:56 Completed build in 13m 07s on Fri, 17 Nov, 10:56 AM Test Summary: 57617 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1249
-
Oliver Hader commented on patch set 1 03/07/18, 12:30
Reply
True, the table is not there anymore. But still in v9 the pid value of the page in default language is used a reference to aggregate other records. -
Oliver Hader commented on patch set 1 CR -1 03/07/18, 12:34
On it... -
Oliver Hader commented on patch set 1 03/07/18, 12:48
DataHandler.php:1586With the existing code, there are some assumptions wrong already. The behavior of this method only considers live default language records. For instance switching the doktype for a localized page should probably only check localized records (or all for a particular table if cannot be localized). -
Oliver Hader uploaded patch set 2 03/07/18, 13:59
-
Oliver Hader voted on patch set 2 CR -1 03/07/18, 14:04
-
Oliver Hader uploaded patch set 3 03/07/18, 14:05
-
Oliver Hader voted on patch set 3 V +1 CR +1 03/07/18, 14:05
-
TYPO3com voted on patch set 2 V +1 03/07/18, 14:10 Completed build in 10m 44s on Wed, 7 Mar, 03:10 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2021
-
TYPO3com voted on patch set 3 V +1 03/07/18, 14:20 Completed build in 15m 02s on Wed, 7 Mar, 03:20 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2022
-
Oliver Hader voted on patch set 3 V +2 CR +2 03/07/18, 18:43
-
Oliver Hader merged patch set 4 03/07/18, 18:43