Review main Merged

54677[BUGFIX] GIFBUILDER files cannot be delivered via web server

Oliver Hader CR +2 V +2 Easy +1 −1 updated 11/20/17, 23:32

Commit message

GIFBUILDER uses provided file names and text snippets in order to
generate the final name for files to be written to. In case text
snippets start with a dot, this is also reflected into the file
name - preventing some web servers to deliver the file since it's
considered to be internal.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Georg Ringer +1
  • Verified V +2
    • Stefan Neufeind +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Oliver Hader uploaded patch set 1 11/17/17, 13:54

  2. TYPO3com voted on patch set 1 V +1 11/17/17, 14:04 Completed build in 10m 09s on Fri, 17 Nov, 03:04 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16464

  3. Alexander Schnitzler commented on patch set 1 11/17/17, 16:18

    GifBuilder.php:702

    Why not put that into the cleanFileName method? It already trims trailing dots, it could also trim leading dots.
  4. Stefan Neufeind commented on patch set 1 11/17/17, 18:23

    GifBuilder.php:702 Reply

    would be a larger api-change then. but with a breaking-rst maybe we could ...
  5. Alexander Schnitzler commented on patch set 1 11/18/17, 07:39

    GifBuilder.php:702 Reply

    Just seen, that this method is deprecated anyway. So, maybe this fix here is just ok and there will be a real good solution in the future.
  6. Georg Ringer voted on patch set 1 CR +1 V +1 11/20/17, 19:35

  7. Stefan Neufeind voted on patch set 1 CR +2 V +2 11/20/17, 23:32

  8. Gerrit merged patch set 1 11/20/17, 23:32

  9. Stefan Neufeind commented on patch set 2 11/20/17, 23:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1437c5bd4d72e1e20a50b3a0a519224a9cc765ae