Review TYPO3_8-7 Abandoned

54691[BUGFIX] Fix classname of success button in install tool

Markus Günther CR 0 V 0 Easy +1 −1 updated 11/20/17, 13:20

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 1216

  1. Markus Günther uploaded patch set 1 11/20/17, 09:58

  2. Frans Saris voted on patch set 1 CR +1 11/20/17, 10:02

  3. Josef Glatz voted on patch set 1 CR +1 V +1 11/20/17, 10:05

  4. TYPO3com voted on patch set 1 V +1 11/20/17, 10:06 Completed build in 08m 11s on Mon, 20 Nov, 11:06 AM Test Summary: 57617 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1263

  5. Alexander Opitz commented on patch set 1 CR -1 V +1 11/20/17, 10:31

    This also happens in master.
  6. Markus Günther commented on patch set 1 11/20/17, 10:37

    Did not expect that ...
  7. Markus Günther updated the commit message in patch set 2 11/20/17, 10:50

  8. TYPO3com voted on patch set 2 V +1 11/20/17, 11:04 Completed build in 13m 35s on Mon, 20 Nov, 12:04 PM Test Summary: 57617 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1265

  9. Markus Günther updated the commit message in patch set 3 11/20/17, 11:55

  10. TYPO3com voted on patch set 3 V +1 11/20/17, 12:06 Completed build in 10m 44s on Mon, 20 Nov, 01:06 PM Test Summary: 57617 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1267

  11. Alexander Opitz commented on patch set 3 11/20/17, 13:00

    Can you please push a patch for master first?
  12. Markus Günther commented on patch set 3 11/20/17, 13:05

    We have a change for master https://review.typo3.org/#/c/54693/
  13. Markus Günther commented on patch set 3 11/20/17, 13:05

    And for 7.6 but there the error is different https://review.typo3.org/#/c/54695/
  14. Alexander Opitz updated the commit message in patch set 4 11/20/17, 13:08

  15. TYPO3com voted on patch set 4 V +1 11/20/17, 13:17 Completed build in 09m 05s on Mon, 20 Nov, 02:17 PM Test Summary: 57617 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1269

  16. Alexander Opitz abandoned the change 11/20/17, 13:20

    Need to abandone as Change-Id isn't reladed by gerrit. Will create new one after master merge.