54693[BUGFIX] Fix class name of success button in the install tool
Commit message
Review
-
Code review CR +2
- Alexander Opitz +2
- Tymoteusz Motylewski +1
-
Verified V +2
- Alexander Opitz +2
- Tymoteusz Motylewski +1
- TYPO3com +1 CI
Files 1
Review log 1114
-
Markus Günther uploaded patch set 1 11/20/17, 10:47
-
TYPO3com voted on patch set 1 V +1 11/20/17, 10:58 Completed build in 11m 07s on Mon, 20 Nov, 11:58 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16489
-
Markus Günther updated the commit message in patch set 2 11/20/17, 11:54
-
TYPO3com voted on patch set 2 V +1 11/20/17, 12:06 Completed build in 11m 59s on Mon, 20 Nov, 01:06 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16491
-
Wouter Wolters voted on patch set 2 CR +1 V +1 11/20/17, 12:26
-
Tymoteusz Motylewski updated the commit message in patch set 3 11/20/17, 12:57
-
Tymoteusz Motylewski voted on patch set 3 CR +1 V +1 11/20/17, 13:02
-
Tymoteusz Motylewski commented on patch set 3 11/20/17, 13:02
The file has different name in v8 and v7, but the issue is still there. -
Markus Günther commented on patch set 3 11/20/17, 13:04
Did push the change for each major version. -
TYPO3com voted on patch set 3 V +1 11/20/17, 13:06 Completed build in 08m 54s on Mon, 20 Nov, 02:06 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16495
-
Alexander Opitz commented on patch set 3 CR -1 11/20/17, 13:16
Gerrit do not get all 3 patchsets together as they had different Change-Ids ... so short hold on to clear the way how to proceed here. -
Alexander Opitz voted on patch set 3 CR +2 V +2 11/20/17, 13:21
-
Gerrit merged patch set 3 11/20/17, 13:21
-
Alexander Opitz commented on patch set 4 11/20/17, 13:35
Markus Günther: Thanks for your patch. Backporting will be done after a patch gets finally merged into master. For more reading: https://slack-redir.net/link?url=https%3A%2F%2Fdocs.typo3.org%2Ftypo3cms%2FContributionWorkflowGuide%2FAppendix%2FGeneralTopics%2FLifeOfAPatch.html%23backporting-a-change-to-other-branches&v=3