Review main Merged

54699[BUGFIX] Fix sorting extensions in "Get Extensions" module

Nicole Hummel CR +2 V +2 Easy +1 −2 updated 11/20/17, 19:29

Commit message

During some Doctrine cleanup the constraint for fetching extension by
extension key got messed up. This patch removes double named parameter
in search constraint.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Nicole Hummel uploaded patch set 1 11/20/17, 14:34

  2. TYPO3com voted on patch set 1 V +1 11/20/17, 14:43 Completed build in 09m 07s on Mon, 20 Nov, 03:43 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16499

  3. Andreas Kienast updated the commit message in patch set 2 11/20/17, 14:53

  4. Andreas Kienast voted on patch set 2 CR +1 11/20/17, 14:53

  5. TYPO3com voted on patch set 2 V +1 11/20/17, 15:02 Completed build in 09m 46s on Mon, 20 Nov, 04:02 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16500

  6. Andreas Kienast voted on patch set 2 V +1 11/20/17, 15:38

  7. Wouter Wolters voted on patch set 2 CR +1 11/20/17, 15:44

  8. Georg Ringer voted on patch set 2 CR +2 V +2 11/20/17, 19:29

  9. Gerrit merged patch set 2 11/20/17, 19:29

  10. Georg Ringer commented on patch set 3 11/20/17, 19:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit aa93204320b9a804bc069a6857f34120c8ce1eda