Review main Merged

54713[BUGFIX] Fix thrown \InvalidArgumentException in access module

Andreas Kienast CR +2 V +2 Easy +10 −8 updated 11/21/17, 21:39

Commit message

The returnUrl is not available if the access module is accessed via
context menu of the page tree. The module now checks whether the
returnUrl is available and renders the close button only in such case.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Andreas Kienast uploaded patch set 1 11/21/17, 07:11

  2. TYPO3com voted on patch set 1 V +1 11/21/17, 07:21 Completed build in 09m 59s on Tue, 21 Nov, 08:21 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16517

  3. Georg Ringer voted on patch set 1 CR +1 V +1 11/21/17, 07:27

  4. Wouter Wolters voted on patch set 1 CR +1 11/21/17, 08:30

  5. Riccardo De Contardi voted on patch set 1 V +1 11/21/17, 20:18

  6. Wouter Wolters voted on patch set 1 CR +2 V +2 11/21/17, 21:39

  7. Gerrit merged patch set 1 11/21/17, 21:39

  8. Wouter Wolters commented on patch set 2 11/21/17, 21:39

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 93fdaeefb15b374d49945dd7b81074c59e9bb622