Review main Merged

54726[BUGFIX] Use correct runtime cache identifier for locked records

Benni Mack CR +2 V +2 Easy +3 −3 updated 11/23/17, 10:04

Commit message

The runtime cache was re-built wrong by using
a custom identifer, thus being called EVERY time a
record is checked. This puts the pagetree DB queries in half.

A simple check (like done previously with $GLOBALS['LOCKED_RECORDS'])
to a simple identifier solves this issue.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1518

  1. Benni Mack uploaded patch set 1 11/22/17, 22:44

  2. Benni Mack commented on patch set 1 11/22/17, 22:46

  3. Oliver Hader voted on patch set 1 CR +1 11/22/17, 22:49

  4. TYPO3com voted on patch set 1 V +1 11/22/17, 22:54 Completed build in 09m 29s on Wed, 22 Nov, 11:54 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16552

  5. Markus Klein updated the commit message in patch set 2 11/22/17, 23:37

  6. Markus Klein voted on patch set 2 CR +1 11/22/17, 23:41

  7. Markus Klein voted on patch set 2 V +1 11/22/17, 23:45

  8. TYPO3com voted on patch set 2 V +1 11/22/17, 23:47 Completed build in 10m 06s on Thu, 23 Nov, 12:47 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16553

  9. Frans Saris commented on patch set 2 CR +1 11/23/17, 06:10

    Maybe also add a `?? false` to the return to prevent php notices.
  10. Georg Ringer voted on patch set 2 CR +1 V +1 11/23/17, 06:50

  11. Tymoteusz Motylewski commented on patch set 3 11/23/17, 08:03

    Published edit on patch set 2.
  12. Tymoteusz Motylewski commented on patch set 3 CR +1 V +1 11/23/17, 08:08

    in my test case (fetching 1000 nodes at once) in lowered the execution time from 3s to 2s. Thats really great!
  13. Georg Ringer voted on patch set 3 CR +1 V +1 11/23/17, 08:13

  14. TYPO3com voted on patch set 3 V +1 11/23/17, 08:13 Completed build in 09m 53s on Thu, 23 Nov, 09:13 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16556

  15. Wouter Wolters voted on patch set 3 CR +1 11/23/17, 08:20

  16. Andreas Kienast voted on patch set 3 CR +2 V +2 11/23/17, 10:03

  17. Gerrit merged patch set 3 11/23/17, 10:03

  18. Andreas Kienast commented on patch set 4 11/23/17, 10:04

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e3f658981c6aab69e7516f650ef5d91659c7d460