54728[BUGFIX] Set `$this->altPageTitle` in TSFE
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 89
-
Andreas Kienast uploaded patch set 1 11/23/17, 10:02
-
TYPO3com voted on patch set 1 V +1 11/23/17, 10:13 Completed build in 10m 39s on Thu, 23 Nov, 11:13 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16560
-
Benni Mack commented on patch set 1 CR -2 11/24/17, 20:41
need to investigate this... -
Benni Mack commented on patch set 1 11/29/17, 18:38
TypoScriptFrontendController.php:3180OK. so PageGenerator sets this to page['title'], nav_title is there for navigation/menus, why should it be set here? -
Andreas Kienast commented on patch set 1 11/29/17, 18:41
In short: customer request :) Customer wants to render only the regular page title in menus and the nav_title as <title> tag, if available -
Benni Mack commented on patch set 1 11/29/17, 18:43
Dude, then this is not a bug fix nor a feature request. altPageTitle is for extensions to override the title tag (e.g. news), and hard-coding this to nav_title is like a 0.01% issue. I suggest you really simply go with https://docs.typo3.org/typo3cms/TyposcriptReference/Setup/Config/Index.html#titletagfunction, we use this at 80% of our installations. -
Mathias Schreiber commented on patch set 1 11/29/17, 18:50
config.pageTitle.field = nav_title//title. Don't worry, happens to all of us every once in a while :) -
Andreas Kienast commented on patch set 1 11/29/17, 18:54
K -
Andreas Kienast abandoned the change 11/29/17, 18:54