54750[BUGFIX] Better sorting localizing records from non-default language
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 4
- Bug #83079wrong sorting of content elements when translating using non-default-language CEs as source
- Bug #83469Translation of translations break sorting in tt_content
- Task #85300Improve record sorting performance
- Bug #84951Localization: Copying new record in existing localization has off-by-one issue
Files 16
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+86 −61
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/copyContentToLanguageFromNonDefaultLanguage.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguage.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguageWithAllContentElements.csvnew+43 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguageWSynchronizationDefault.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguageWSynchronizationSource.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+9 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+51 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/copyContentToLanguageFromNonDefaultLanguage.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguage.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguageWithAllContentElements.csvnew+50 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+10 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/copyContentToLanguageFromNonDefaultLanguage.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/localizeContentFromNonDefaultLanguage.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/copyContentToLanguageFromNonDefaultLanguage.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/localizeContentFromNonDefaultLanguage.csv+1 −1
Review log 4476
Show 2851 earlier messages
-
Tobias Liebig uploaded patch set 1 11/24/17, 21:07
-
Tobias Liebig rebased onto patch set 2 11/24/17, 21:08
-
TYPO3com voted on patch set 1 V -1 11/24/17, 21:16 Completed build in 09m 33s on Fri, 24 Nov, 10:16 PM Test Summary: 20 of 57165 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16594
-
TYPO3com voted on patch set 2 V -1 11/24/17, 21:19 Completed build in 11m 26s on Fri, 24 Nov, 10:19 PM Test Summary: 20 of 57165 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16595
-
Tobias Liebig uploaded patch set 3 11/24/17, 21:44
-
Tobias Liebig updated the commit message in patch set 4 11/24/17, 21:46
-
Tobias Liebig updated the commit message in patch set 5 11/24/17, 21:47
-
TYPO3com voted on patch set 5 V +1 11/24/17, 22:00 Completed build in 12m 52s on Fri, 24 Nov, 11:00 PM Test Summary: 56806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16599
-
TYPO3com voted on patch set 3 V +1 11/24/17, 22:00 Completed build in 15m 26s on Fri, 24 Nov, 11:00 PM Test Summary: 56806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16596
-
TYPO3com voted on patch set 4 V +1 11/24/17, 22:01 Completed build in 14m 28s on Fri, 24 Nov, 11:01 PM Test Summary: 56806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16597
-
Mathias Schreiber uploaded patch set 6 02/06/18, 09:21
-
TYPO3com voted on patch set 6 V +1 02/06/18, 09:28 Completed build in 06m 36s on Tue, 6 Feb, 10:28 AM Test Summary: 30420 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19002
-
Andreas Wolf uploaded patch set 7 03/16/18, 10:20
-
TYPO3com voted on patch set 7 V -1 03/16/18, 10:30 Completed build in 10m 53s on Fri, 16 Mar, 11:30 AM Test Summary: 30883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21185
-
Andreas Wolf rebased onto patch set 8 06/05/18, 19:09
-
TYPO3com voted on patch set 8 V -1 06/05/18, 19:09 Completed build in 09s on Tue, 5 Jun, 09:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24080
-
Andreas Wolf uploaded patch set 9 06/05/18, 19:12
-
TYPO3com voted on patch set 9 V -1 06/05/18, 19:21 Completed build in 08m 21s on Tue, 5 Jun, 09:21 PM Test Summary: 20 of 31394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24081
-
Andreas Wolf uploaded patch set 10 06/22/18, 20:25
-
TYPO3com voted on patch set 10 V -1 06/22/18, 20:32 Completed build in 07m 42s on Fri, 22 Jun, 10:32 PM Test Summary: 330 of 32959 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24670
-
Tymoteusz Motylewski commented on patch set 10 08/09/18, 12:11
this looks like a related/duplicated to https://review.typo3.org/#/c/55508/ -
Tymoteusz Motylewski rebased onto patch set 11 08/09/18, 12:11
-
TYPO3com voted on patch set 11 V -1 08/09/18, 12:18 Completed build in 06m 39s on Thu, 9 Aug, 02:18 PM Test Summary: 330 of 33769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26293
-
Benni Mack rebased onto patch set 12 10/01/18, 18:12
-
TYPO3com voted on patch set 12 V -1 10/01/18, 18:38 Completed build in 17m 52s on Mon, 1 Oct, 08:38 PM Test Summary: 336 of 37218 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29219
-
Andreas Kienast uploaded patch set 13 10/01/18, 21:35
-
TYPO3com voted on patch set 13 V -1 10/01/18, 21:48 Completed build in 12m 43s on Mon, 1 Oct, 11:48 PM Test Summary: 30 of 38158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29242
-
Benni Mack updated the commit message in patch set 14 12/14/18, 09:57
-
TYPO3com voted on patch set 14 V -1 12/14/18, 10:41 Completed build in 39m 20s on Fri, 14 Dec, 11:41 AM Test Summary: 30 of 49175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30688
-
Benni Mack uploaded patch set 15 09/26/19, 11:25
-
TYPO3com voted on patch set 15 V -1 09/26/19, 11:36 Completed build in 11m 28s on Thu, 26 Sep, 11:36 AM Test Summary: 40241 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36853
-
Markus Klein commented on patch set 15 09/26/19, 13:02
LocalizeTest.php:39Declaration of TYPO3\CMS\Core\Tests\Functional\DataHandling\DataHandler\LocalizeTest::setUp() must be compatible with TYPO3\CMS\Core\Tests\Functional\DataHandling\AbstractDataHandlerActionTestCase::setUp() -
Markus Klein uploaded patch set 16 10/25/19, 19:01
-
TYPO3com voted on patch set 16 V -1 10/25/19, 19:04 Completed build in 39s on Fri, 25 Oct, 07:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37734
-
Markus Klein commented on patch set 17 10/25/19, 19:36
Published edit on patch set 16. -
TYPO3com voted on patch set 17 V -1 10/25/19, 20:03 Completed build in 19m 51s on Fri, 25 Oct, 08:03 PM Test Summary: 40551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37741
-
Markus Klein commented on patch set 18 10/25/19, 20:23
Published edit on patch set 17. -
TYPO3com voted on patch set 18 V -1 10/25/19, 20:34 Completed build in 10m 51s on Fri, 25 Oct, 08:34 PM Test Summary: 30 of 48172 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37743
-
Benni Mack rebased onto patch set 19 12/03/19, 22:30
-
TYPO3com voted on patch set 19 V -1 12/03/19, 22:37 Completed build in 07m 00s on Tue, 3 Dec, 10:37 PM Test Summary: 30 of 69093 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39088
-
Oliver Hader rebased onto patch set 20 04/06/20, 07:48
-
TYPO3com voted on patch set 20 V -1 04/06/20, 08:01 Completed build in 13m 05s on Mon, 6 Apr, 08:01 AM Test Summary: 30 of 73856 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2215
-
Benni Mack uploaded patch set 21 11/10/21, 13:24
-
Benni Mack commented on patch set 21 11/10/21, 13:24
LocalizeTest.php:39ReplyDone -
core-ci voted on patch set 21 V -1 11/10/21, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19124
-
Benni Mack uploaded patch set 22 11/10/21, 17:32
-
core-ci voted on patch set 22 V -1 11/10/21, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19134
-
Benni Mack uploaded patch set 23 11/10/21, 18:13
-
core-ci voted on patch set 23 V -1 11/10/21, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19138
-
Christian Kuhn commented on patch set 23 11/10/21, 22:36
will work on this. -
Benni Mack updated the commit message in patch set 24 11/18/21, 10:46
-
core-ci voted on patch set 24 V -1 11/18/21, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19469
-
Christian Kuhn rebased onto patch set 25 11/18/21, 16:28
-
core-ci voted on patch set 25 V -1 11/18/21, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19524
-
Christian Kuhn uploaded patch set 26 11/19/21, 11:00
-
Christian Kuhn commented on patch set 26 CR -1 11/19/21, 11:00
will re-create the test sets. -
core-ci voted on patch set 26 V +1 11/19/21, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19556
-
Christian Kuhn uploaded patch set 27 11/19/21, 17:13
-
core-ci voted on patch set 27 V -1 11/19/21, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19567
-
Christian Kuhn uploaded patch set 28 11/19/21, 17:37
-
core-ci voted on patch set 28 V -1 11/19/21, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19568
-
Christian Kuhn uploaded patch set 29 11/19/21, 18:39
-
core-ci voted on patch set 29 V -1 11/19/21, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19569
-
Christian Kuhn uploaded patch set 30 11/19/21, 18:42
-
core-ci voted on patch set 30 V +1 11/19/21, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19570
-
Christian Kuhn uploaded patch set 31 11/19/21, 19:45
-
core-ci voted on patch set 31 V -1 11/19/21, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19573
-
Christian Kuhn uploaded patch set 32 11/19/21, 20:01
-
core-ci voted on patch set 32 V +1 11/19/21, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19574
-
Christian Kuhn commented on patch set 32 11/19/21, 20:48
DataHandler.php:7756that's the key change. -
Christian Kuhn commented on patch set 32 11/19/21, 21:09
DataHandler.php:7756ReplyDone -
Stefan Bürk voted on patch set 32 V +1 CR +1 11/19/21, 21:13
-
Oli Bartsch voted on patch set 32 CR +1 11/20/21, 00:05
-
Benni Mack voted on patch set 32 V +1 CR +1 11/20/21, 08:04
-
Christian Kuhn voted on patch set 32 V +2 CR +2 11/20/21, 10:34
-
Christian Kuhn merged patch set 33 11/20/21, 10:34