Review main Merged

54752[TASK] Move llXmlAutoFileName() into AbstractXmlParser

Benni Mack CR +2 V +2 Normal +94 −3 updated 11/27/17, 15:37

Commit message

The global function in GeneralUtility is moved into the AbstractXmlParser.

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 79

  1. Benni Mack uploaded patch set 1 11/24/17, 22:25

  2. TYPO3com voted on patch set 1 V +1 11/24/17, 22:35 Completed build in 10m 25s on Fri, 24 Nov, 11:35 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16603

  3. Jörg Bösche voted on patch set 1 CR +1 11/27/17, 09:26

  4. Christian Kuhn commented on patch set 1 11/27/17, 11:49

    AbstractXmlParser.php:93

    Please hint this returns the absolute path to the file.
  5. Christian Kuhn uploaded patch set 2 11/27/17, 11:57

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 11/27/17, 11:58

  7. TYPO3com voted on patch set 2 V +1 11/27/17, 12:08 Completed build in 11m 39s on Mon, 27 Nov, 01:08 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16648

  8. Susi Moog voted on patch set 2 CR +2 V +2 11/27/17, 15:37

  9. Gerrit merged patch set 2 11/27/17, 15:37