Review main Merged

54754[BUGFIX] Use config.extTarget for menu links to external URLs

Benni Mack CR +2 V +2 Easy +3 −0 updated 11/27/17, 13:28

Commit message

Review

  • Code review CR +2
    • Riccardo De Contardi +2
    • Joerg Kummer +1
    • Wouter Wolters +1
    • Jörg Bösche +1
    • Henning Liebe +1
  • Verified V +2
    • Riccardo De Contardi +2
    • Joerg Kummer +1
    • Jörg Bösche +1
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Benni Mack uploaded patch set 1 11/24/17, 22:28

  2. TYPO3com voted on patch set 1 V +1 11/24/17, 22:41 Completed build in 12m 58s on Fri, 24 Nov, 11:41 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16605

  3. Joerg Kummer commented on patch set 1 V -1 11/25/17, 19:40

    Incompatible with TYPO3 v8.7
  4. Joerg Kummer updated the commit message in patch set 2 11/25/17, 19:41

  5. TYPO3com voted on patch set 2 V +1 11/25/17, 19:50 Completed build in 09m 01s on Sat, 25 Nov, 08:50 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16621

  6. Joerg Kummer voted on patch set 2 CR +1 V +1 11/25/17, 19:52

  7. Riccardo De Contardi voted on patch set 2 V +1 11/25/17, 20:28

  8. Wouter Wolters voted on patch set 2 CR +1 11/26/17, 11:59

  9. Jörg Bösche voted on patch set 2 CR +1 V +1 11/27/17, 09:12

  10. Henning Liebe voted on patch set 2 CR +1 V +1 11/27/17, 09:52

  11. Riccardo De Contardi voted on patch set 2 CR +2 V +2 11/27/17, 13:26

  12. Gerrit merged patch set 2 11/27/17, 13:28