Review main Merged

54756[BUGFIX] Only update fe_users.is_online if user is logged in

Benni Mack CR +2 V +2 Easy +27 −14 updated 11/27/17, 21:25

Commit message

The field is_online is updated in TSFE right after a user has authenticated,
but if the user has no usergroup, he/she is not logged in.

The update should be moved in the TSFE->fe_user and the check
should only be called when a logged-in user is found.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Łukasz Uznański +1
    • Andreas Kienast +1
    • Henning Liebe +1
    • Jörg Bösche +1
    • Susi Moog +1
  • Verified V +2
    • Wouter Wolters +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Benni Mack uploaded patch set 1 11/24/17, 22:35

  2. TYPO3com voted on patch set 1 V -1 11/24/17, 22:35 Completed build in 08s on Fri, 24 Nov, 11:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16607

  3. Benni Mack uploaded patch set 2 11/24/17, 22:36

  4. TYPO3com voted on patch set 2 V +1 11/24/17, 22:47 Completed build in 10m 45s on Fri, 24 Nov, 11:47 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16608

  5. Andreas Kienast voted on patch set 2 CR +1 11/27/17, 07:37

  6. Henning Liebe voted on patch set 2 CR +1 11/27/17, 09:06

  7. Jörg Bösche voted on patch set 2 CR +1 11/27/17, 09:06

  8. Łukasz Uznański voted on patch set 2 CR +1 11/27/17, 15:05

  9. Susi Moog voted on patch set 2 CR +1 V +1 11/27/17, 18:47

  10. Wouter Wolters voted on patch set 2 CR +1 11/27/17, 21:21

  11. Wouter Wolters voted on patch set 2 CR +2 V +2 11/27/17, 21:25

  12. Gerrit merged patch set 2 11/27/17, 21:25