Review main Abandoned

54764[WIP][BUGFIX] Fix tabs in Safari on Mac in incognito mode

Frank Nägler CR 0 V 0 Easy +18 −2 updated 02/13/18, 21:08

Commit message

It seams that the bug is fixed in Safari 11 and only exists in Safari < 11

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 78

  1. Frank Nägler uploaded patch set 1 11/25/17, 21:19

  2. TYPO3com voted on patch set 1 V +1 11/25/17, 21:29 Completed build in 09m 42s on Sat, 25 Nov, 10:29 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16623

  3. Andreas Kienast commented on patch set 1 11/27/17, 07:19

    Client.ts:36

    Don't we get this message everytime someone switches a tab now. That would be super annoying :) Nevertheless, it seems the patch makes sense, but can't test (Safari 11.01 here)

    Client.ts:42

    "Possible" sounds like "there could be", but there is an actual issue. We should find a better wording here.
  4. Frank Nägler commented on patch set 1 11/27/17, 08:04

    Client.ts:36 Reply

    agree, that this could be annoying, but where do you want to save the information, that the message was already displayed? In the localStorage? ;)
  5. Andreas Kienast commented on patch set 1 11/27/17, 08:17

    Client.ts:36 Reply

    Are cookies possible? If yes, move to constructor I'd say.
  6. Andreas Kienast commented on patch set 1 12/06/17, 17:30

    *ping* What's the progress here?
  7. Frank Nägler commented on patch set 1 01/06/18, 11:01

    @Andy: we need a system with safari 10 on os x to test the patch.
  8. Frank Nägler abandoned the change 02/13/18, 21:08

    will close the issue, because it is very rare use case