54768[CLEANUP] Remove/Replace non-standard phpdoc annotations
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2
- Wouter Wolters +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 32
- typo3/sysext/about/Classes/Domain/Model/Extension.php+0 −2
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php1+1 −1
- typo3/sysext/backend/Classes/Controller/Page/LocalizationController.php+2 −2
- typo3/sysext/backend/Classes/Tree/TreeNodeCollection.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/FormInlineAjaxControllerTest.php+2 −2
- typo3/sysext/core/Classes/Cache/CacheManager.php+0 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+9 −6
- typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php+1 −1
- typo3/sysext/core/Classes/Http/JsonResponse.php+1 −1
- typo3/sysext/core/Classes/Http/Uri.php+2 −2
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+0 −4
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+0 −4
- typo3/sysext/documentation/Classes/Domain/Model/Document.php+0 −2
- typo3/sysext/documentation/Classes/Domain/Model/DocumentFormat.php+0 −2
- typo3/sysext/documentation/Classes/Domain/Model/DocumentTranslation.php+0 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfMethods.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithTags.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+1 −2
Show 12 more files
- typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php+7 −7
- typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php+3 −3
- typo3/sysext/form/Classes/ViewHelpers/GridColumnClassAutoConfigurationViewHelper.php+0 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php+0 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+0 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+5 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −2
- typo3/sysext/install/Classes/Service/EnableFileService.php+3 −3
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+16 −16
- typo3/sysext/scheduler/Tests/Unit/CronCommand/CronCommandTest.php+1 −1
Review log 911
-
Alexander Schnitzler uploaded patch set 1 11/26/17, 16:46
-
TYPO3com voted on patch set 1 V -1 11/26/17, 16:54 Completed build in 08m 18s on Sun, 26 Nov, 05:54 PM Test Summary: 72 of 57161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16624
-
Alexander Schnitzler uploaded patch set 2 11/26/17, 17:06
-
TYPO3com voted on patch set 2 V +1 11/26/17, 17:15 Completed build in 09m 15s on Sun, 26 Nov, 06:15 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16625
-
Alexander Schnitzler commented on patch set 2 11/26/17, 17:24
-
Georg Ringer voted on patch set 2 CR +1 V +1 11/26/17, 18:09
-
Oliver Klee voted on patch set 2 CR +1 11/26/17, 19:25
-
Wouter Wolters voted on patch set 2 CR +2 V +2 11/26/17, 22:30
-
Gerrit merged patch set 2 11/26/17, 22:30
-
Mathias Brodala commented on patch set 3 11/27/17, 08:30
I guess this could be solved with custom annotation classes? -
Alexander Schnitzler commented on patch set 3 11/28/17, 07:25
Reply
Yes
ShortcutToolbarItem.php:40