Review main Merged

54768[CLEANUP] Remove/Replace non-standard phpdoc annotations

Alexander Schnitzler CR +2 V +2 Normal +60 −80 updated 11/28/17, 07:25

Commit message

Over the years many different non-standard phpdoc anotations
made it into that core which will now break the AnnotationReader
of doctrine. Therefore either all these annotations need to be
ignored or removed/replaced.

As it is easier to actually solve the issues instead of hiding them
this patch removes or replaces most non-standard annotations and
configures to ignore some of them like @extensionScannerIgnoreFile
and @extensionScannerIgnoreLine which are introduced by TYPO3 but
cannot be replaced as they provide a decent functionality

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 32

Show 12 more files

Review log 911

  1. Alexander Schnitzler uploaded patch set 1 11/26/17, 16:46

  2. TYPO3com voted on patch set 1 V -1 11/26/17, 16:54 Completed build in 08m 18s on Sun, 26 Nov, 05:54 PM Test Summary: 72 of 57161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16624

  3. Alexander Schnitzler uploaded patch set 2 11/26/17, 17:06

  4. TYPO3com voted on patch set 2 V +1 11/26/17, 17:15 Completed build in 09m 15s on Sun, 26 Nov, 06:15 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16625

  5. Alexander Schnitzler commented on patch set 2 11/26/17, 17:24

    ShortcutToolbarItem.php:40

  6. Georg Ringer voted on patch set 2 CR +1 V +1 11/26/17, 18:09

  7. Oliver Klee voted on patch set 2 CR +1 11/26/17, 19:25

  8. Wouter Wolters voted on patch set 2 CR +2 V +2 11/26/17, 22:30

  9. Gerrit merged patch set 2 11/26/17, 22:30

  10. Mathias Brodala commented on patch set 3 11/27/17, 08:30

    I guess this could be solved with custom annotation classes?
  11. Alexander Schnitzler commented on patch set 3 11/28/17, 07:25

    Reply

    Yes