Review main Merged

54786[BUGFIX] fix missing l18n fields in blog tag table

Sebastian Hofer CR +2 V +2 Easy +9 −4 updated 11/27/17, 15:42

Commit message

The field l18n_parent was missing in table
tx_blogexample_domain_model_tag, but configured in TCA.
This causes an exception with adding a new tag in BE.
Also the field l18n_diffsource was missing in TCA and database.

* Add the fields l18n_parent and l18_diffsource to
  the databse table tx_blogexample_domain_model_tag
* Add TCA configuration for field l18n_diffsource to
  tx_blogexample_domain_model_tag TCA

Also add missing icon and label for
tx_blogexample_domain_model_dateexample.

Remove "allow tables on standard pages". This is not
necessary.

Review

  • Code review CR +2
    • Markus Klein +2
    • Georg Ringer +1
    • Markus Hölzle +1
    • Łukasz Uznański +1
  • Verified V +2
    • Markus Klein +2
    • Georg Ringer +1
    • Łukasz Uznański +1
    • TYPO3com +1 CI

Files 5

Review log 1422

  1. Sebastian Hofer uploaded patch set 1 11/27/17, 12:00

  2. Sebastian Hofer updated the commit message in patch set 2 11/27/17, 12:02

  3. TYPO3com voted on patch set 1 V +1 11/27/17, 12:13 Completed build in 12m 49s on Mon, 27 Nov, 01:13 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16650

  4. TYPO3com voted on patch set 2 V +1 11/27/17, 12:15 Completed build in 13m 05s on Mon, 27 Nov, 01:15 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16651

  5. Markus Klein updated the commit message in patch set 3 11/27/17, 12:55

  6. TYPO3com voted on patch set 3 V +1 11/27/17, 13:05 Completed build in 10m 09s on Mon, 27 Nov, 02:05 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16657

  7. Oliver Klee commented on patch set 4 11/27/17, 13:09

    Published edit on patch set 3.
  8. Sebastian Hofer uploaded patch set 5 11/27/17, 13:14

  9. Sebastian Hofer updated the commit message in patch set 6 11/27/17, 13:15

  10. Sebastian Hofer updated the commit message in patch set 7 11/27/17, 13:16

  11. Sebastian Hofer uploaded patch set 8 11/27/17, 13:20

  12. TYPO3com voted on patch set 4 V +1 11/27/17, 13:20 Completed build in 11m 15s on Mon, 27 Nov, 02:20 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16659

  13. TYPO3com voted on patch set 5 V +1 11/27/17, 13:28 Completed build in 14m 08s on Mon, 27 Nov, 02:28 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16661

  14. TYPO3com voted on patch set 6 V +1 11/27/17, 13:28 Completed build in 13m 06s on Mon, 27 Nov, 02:28 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16662

  15. TYPO3com voted on patch set 8 V +1 11/27/17, 13:28 Completed build in 08m 37s on Mon, 27 Nov, 02:28 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16665

  16. TYPO3com voted on patch set 7 V +1 11/27/17, 13:29 Completed build in 12m 40s on Mon, 27 Nov, 02:29 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16663

  17. Markus Hölzle voted on patch set 8 CR +1 11/27/17, 13:31

  18. Georg Ringer voted on patch set 8 CR +1 V +1 11/27/17, 14:01

  19. Łukasz Uznański voted on patch set 8 CR +1 V +1 11/27/17, 15:31

  20. Markus Klein voted on patch set 8 CR +2 V +2 11/27/17, 15:42

  21. Gerrit merged patch set 8 11/27/17, 15:42

  22. Markus Klein commented on patch set 9 11/27/17, 15:42

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d1d4a27aa59b6ea5a764287be9509d5b423b54d6