Review main Merged

54788[BUGFIX] Send correct Cache-Control header if no client side caching

Łukasz Uznański CR +2 V +2 Easy +3 −2 updated 11/27/17, 16:02

Commit message

Add 'Cache-Control: no-store' if conditions allowing client caching
are not met. This change will prevent caching content by browser.

Review

  • Code review CR +2
    • Markus Klein +2
    • Pawel Cieslik +1
  • Verified V +2
    • Markus Klein +2
    • Pawel Cieslik +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1418

  1. Łukasz Uznański uploaded patch set 1 11/27/17, 12:26

  2. Łukasz Uznański updated the commit message in patch set 2 11/27/17, 12:31

  3. TYPO3com voted on patch set 1 V +1 11/27/17, 12:37 Completed build in 11m 12s on Mon, 27 Nov, 01:37 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16653

  4. TYPO3com voted on patch set 2 V +1 11/27/17, 12:40 Completed build in 08m 37s on Mon, 27 Nov, 01:40 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16654

  5. Markus Klein updated the commit message in patch set 3 11/27/17, 12:49

  6. Markus Klein voted on patch set 3 CR +1 V +1 11/27/17, 12:50

  7. TYPO3com voted on patch set 3 V +1 11/27/17, 12:59 Completed build in 09m 48s on Mon, 27 Nov, 01:59 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16656

  8. Pawel Cieslik commented on patch set 3 CR +1 V +1 11/27/17, 13:13

    really straightforward :)
  9. Benni Mack commented on patch set 4 11/27/17, 13:28

    Published edit on patch set 3.
  10. Mathias Brodala commented on patch set 4 11/27/17, 13:33

    Nothing for v7 I guess?
  11. TYPO3com voted on patch set 4 V +1 11/27/17, 13:40 Completed build in 11m 54s on Mon, 27 Nov, 02:40 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16667

  12. Pawel Cieslik voted on patch set 4 CR +1 11/27/17, 13:45

  13. Markus Klein commented on patch set 4 11/27/17, 15:38

    @Brodala: v7 too, since this is actually a really hard bug.
  14. Markus Klein voted on patch set 4 CR +1 V +1 11/27/17, 15:40

  15. Pawel Cieslik voted on patch set 4 V +1 11/27/17, 15:57

  16. Markus Klein voted on patch set 4 CR +2 V +2 11/27/17, 16:02

  17. Gerrit merged patch set 4 11/27/17, 16:02

  18. Markus Klein commented on patch set 5 11/27/17, 16:02

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 507a9631a4df5c2b9646cc53f66cac38442647b1