5479[BUGFIX] meaningfulTempFilePrefix is not multi-byte safe
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Helmut Hummel +1
-
Verified V +2
- Jigal van Hemert +2
- Helmut Hummel +1
Issues 1
Files 2
Review log 17
-
Helmut Hummel commented on patch set 1 10/04/11, 20:49
Verified; Looks good to me, but someone else must approve one minor comment, everything else looks goodclass.tslib_gifbuilder.php:736Could be just: $meaningfulPrefix .= '_'; -
Helmut Hummel commented on patch set 1 10/04/11, 20:49
Fails sorry, have to revert my +1 by testing as the original problem seems not to be fixed... I first tested IMAGE only not IMG_RESOURCE -
Helmut Hummel uploaded patch set 2 10/04/11, 20:49
-
Helmut Hummel commented on patch set 2 10/04/11, 20:49
Verified; Looks good to me, but someone else must approve Got it. the special handling in getImgResource() is not needed, as all special characters are thrown away in line 4967 anyway: $filename = preg_replace('/[^A-Za-z0-9_-]/', '', trim($filename)); -
Helmut Hummel commented on patch set 2 10/04/11, 20:49
Hm, when thinking about it again: Why not also throw a way all special characters in the gifbuilder class? Much less effort that handling it correctly (and probably still breaking some weird browsers)... -
Helmut Hummel uploaded patch set 3 10/04/11, 20:49
-
Helmut Hummel uploaded patch set 4 10/04/11, 20:49
-
Helmut Hummel commented on patch set 5 10/04/11, 20:49
Verified; Looks good to me, but someone else must approve OK, Jigal raised a good point, that if utf-8 filesystem is used meaningful prefix for images should also include the characters of the file and not only ascii... -
Helmut Hummel uploaded patch set 5 10/04/11, 20:49
-
Steffen Gebert commented on patch set 2 10/04/11, 20:49
Thanks for your investigations, Helmut! I started fixing this at the wrong place, thus only 50% have been tested and that's why I didn't push it to Gerrit myself. Nevertheless, thanks Jigal for taking care. -
Mr. Jenkins commented on patch set 1 10/04/11, 20:49
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1983/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/04/11, 20:49
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1987/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/04/11, 20:49
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1989/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/04/11, 20:49
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1990/ : SUCCESS -
Mr. Jenkins commented on patch set 5 10/04/11, 20:49
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1991/ : SUCCESS -
Jigal van Hemert commented on patch set 5 V 0 10/04/11, 20:49
by team member; Looks good to me, approved -
Jigal van Hemert merged patch set 5 10/04/11, 20:49