5481[BUGFIX] Module User Settings calls deprecated methods
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
- Helmut Hummel +1
-
Verified V +2
- Steffen Gebert +2
- Helmut Hummel +1
Files 1
Review log 6
-
Helmut Hummel uploaded patch set 2 10/02/11, 16:47
-
Helmut Hummel commented on patch set 2 10/02/11, 16:47
Verified; Looks good to me, but someone else must approve Rather than adding the possibility to call the deprecated methods without deprecation messeage, I would duplicate the code to be sure that the properties are filled correctly for the sake of backwards compatibility -
Steffen Gebert commented on patch set 2 V 0 10/02/11, 16:47
by team member; Looks good to me, approved Thanks! -
Mr. Jenkins commented on patch set 1 10/02/11, 16:47
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1984/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/02/11, 16:47
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1986/ : SUCCESS -
Steffen Gebert merged patch set 2 10/02/11, 16:47