Review main Merged

5481[BUGFIX] Module User Settings calls deprecated methods

Xavier Perseguers CR +2 V +2 Easy +5 −3 updated 06/03/13, 20:49

Commit message

When opening user settings, two deprecated methods are called. The new
methods cannot be used as they combine the business logic into a single
call but do not offer the same information granularity.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Helmut Hummel +1
  • Verified V +2
    • Steffen Gebert +2
    • Helmut Hummel +1

Files 1

Review log 6

  1. Helmut Hummel uploaded patch set 2 10/02/11, 16:47

  2. Helmut Hummel commented on patch set 2 10/02/11, 16:47

    Verified; Looks good to me, but someone else must approve Rather than adding the possibility to call the deprecated methods without deprecation messeage, I would duplicate the code to be sure that the properties are filled correctly for the sake of backwards compatibility
  3. Steffen Gebert commented on patch set 2 V 0 10/02/11, 16:47

    by team member; Looks good to me, approved Thanks!
  4. Mr. Jenkins commented on patch set 1 10/02/11, 16:47

  5. Mr. Jenkins commented on patch set 2 10/02/11, 16:47

  6. Steffen Gebert merged patch set 2 10/02/11, 16:47