Review main Merged

54821[BUGFIX] Also show port when trustedHosts pattern mismatches

Oliver Thiele CR +2 V +2 Easy +4 −3 updated 11/28/17, 12:47

Commit message

Add the port information to the error message when the
trustedHostsPattern mismatches. This is important as
the SERVER_NAME may match, but the SERVER_PORT might be
different from the default ports.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1321

  1. Oliver Thiele uploaded patch set 1 11/28/17, 09:52

  2. TYPO3com voted on patch set 1 V -1 11/28/17, 09:52 Completed build in 08s on Tue, 28 Nov, 10:52 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16774

  3. Oliver Thiele uploaded patch set 2 11/28/17, 09:58

  4. Markus Klein voted on patch set 2 CR +1 V +1 11/28/17, 10:02

  5. Wouter Wolters voted on patch set 2 CR +1 11/28/17, 10:07

  6. TYPO3com voted on patch set 2 V +1 11/28/17, 10:08 Completed build in 10m 15s on Tue, 28 Nov, 11:08 AM Test Summary: 56840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16775

  7. Henning Liebe voted on patch set 2 CR +1 11/28/17, 11:17

  8. Christian Kuhn uploaded patch set 3 11/28/17, 11:21

  9. TYPO3com voted on patch set 3 V -1 11/28/17, 11:33 Completed build in 11m 29s on Tue, 28 Nov, 12:33 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16789

  10. Christian Kuhn uploaded patch set 4 11/28/17, 11:34

  11. Christian Kuhn commented on patch set 4 11/28/17, 11:35

    SetupCheck.php:80

    it's ok to remove the htmlspecialchars() since the flashMessages will be fully quoted anyway.
  12. Christian Kuhn voted on patch set 4 CR +1 V +1 11/28/17, 11:36

  13. Markus Klein commented on patch set 4 11/28/17, 11:36

    SetupCheck.php:80 Reply

    confirmed!
  14. TYPO3com voted on patch set 4 V -1 11/28/17, 11:42 Completed build in 08m 08s on Tue, 28 Nov, 12:42 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16793

  15. TYPO3com commented on patch set 3 11/28/17, 12:12 Completed build in 1h 01m 53s on Tue, 28 Nov, 01:12 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16789

  16. TYPO3com commented on patch set 4 11/28/17, 12:12 Completed build in 46m 38s on Tue, 28 Nov, 01:12 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16793

  17. TYPO3com commented on patch set 4 11/28/17, 12:14 Completed build in 1h 26m 50s on Tue, 28 Nov, 01:14 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16793

  18. Christian Kuhn rebased onto patch set 5 11/28/17, 12:24

  19. TYPO3com voted on patch set 5 V +1 11/28/17, 12:39 Completed build in 14m 47s on Tue, 28 Nov, 01:39 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16802

  20. Markus Klein voted on patch set 5 CR +2 V +2 11/28/17, 12:47

  21. Gerrit merged patch set 5 11/28/17, 12:47