54827[BUGFIX] Handle missing repository mirrors in Languages module
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2535
Show 610 earlier messages
-
Mathias Brodala uploaded patch set 1 11/28/17, 11:06
-
TYPO3com voted on patch set 1 V -1 11/28/17, 11:17 Completed build in 11m 08s on Tue, 28 Nov, 12:17 PM Test Summary: 56864 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16786
-
Mathias Brodala commented on patch set 2 11/28/17, 11:25
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V -1 11/28/17, 11:36 Completed build in 10m 51s on Tue, 28 Nov, 12:36 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16792
-
TYPO3com commented on patch set 2 11/28/17, 12:12 Completed build in 58m 06s on Tue, 28 Nov, 01:12 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16792
-
Christian Kuhn rebased onto patch set 3 11/28/17, 12:25
-
TYPO3com voted on patch set 3 V +1 11/28/17, 12:44 Completed build in 19m 05s on Tue, 28 Nov, 01:44 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16805
-
Wouter Wolters voted on patch set 3 CR +1 V +1 11/28/17, 18:39
-
Nicole Hummel commented on patch set 3 CR -1 11/28/17, 19:32
I would prefer to throw an error in __construct() already. setRepository() should be marked as deprecated and repository can be moved as constructor argument. setRepository() isn't called anywhere else inside the core -
Nicole Hummel commented on patch set 3 11/28/17, 19:33
Otherwise we need to add the if ($this->repository === null) {} check in every function that uses $this->repository
-
Mathias Brodala uploaded patch set 4 12/11/17, 15:13
-
Mathias Brodala uploaded patch set 5 12/11/17, 15:21
-
Mathias Brodala uploaded patch set 6 12/11/17, 15:23
-
TYPO3com voted on patch set 4 V +1 12/11/17, 15:24 Completed build in 11m 29s on Mon, 11 Dec, 04:24 PM Test Summary: 57117 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17585
-
Mathias Brodala uploaded patch set 7 12/11/17, 15:25
-
Mathias Brodala commented on patch set 6 12/11/17, 15:25
> I would prefer to throw an error in __construct() already. > setRepository() should be marked as deprecated and repository can > be moved as constructor argument. setRepository() isn't called > anywhere else inside the core Good idea, done now. -
Mathias Brodala commented on patch set 7 V -1 12/11/17, 15:28
This actually breaks the whole Extensions module. -
TYPO3com voted on patch set 5 V +1 12/11/17, 15:30 Completed build in 09m 01s on Mon, 11 Dec, 04:30 PM Test Summary: 57117 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17586
-
TYPO3com voted on patch set 6 V -1 12/11/17, 15:35 Completed build in 11m 25s on Mon, 11 Dec, 04:35 PM Test Summary: 15 of 57460 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17587
-
TYPO3com voted on patch set 7 V -1 12/11/17, 15:36 Completed build in 10m 42s on Mon, 11 Dec, 04:36 PM Test Summary: 15 of 57460 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17588
-
Mathias Brodala uploaded patch set 8 12/11/17, 15:37
-
TYPO3com voted on patch set 8 V +1 12/11/17, 15:44 Completed build in 07m 07s on Mon, 11 Dec, 04:44 PM Test Summary: 57117 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17589
-
Stefan Neufeind voted on patch set 8 CR +1 12/11/17, 15:54
-
Mathias Brodala commented on patch set 9 12/11/17, 15:58
Published edit on patch set 8. -
Mathias Brodala commented on patch set 9 12/11/17, 15:59
> Patch Set 8: Code-Review+1 Please revote. ;-) -
Stefan Neufeind voted on patch set 9 CR +1 12/11/17, 16:01
-
TYPO3com voted on patch set 9 V +1 12/11/17, 16:07 Completed build in 09m 37s on Mon, 11 Dec, 05:07 PM Test Summary: 57117 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17590
-
Stefan Neufeind commented on patch set 9 V -1 12/13/17, 11:42
Tried to verify it. In general this approach works - I get the error/hint shown in the extension-manager when trying to fetch a new list of extensions. And the exception in the languages-module is gone. But the languages-module does not show a hint what might be wrong. After this patch I get the list of languages, can select one, try to download it and then get "The request has failed" - not the hint pointing to the repository-problem. -
Christian Kuhn commented on patch set 9 CR -1 03/29/18, 14:03
in general, i would rather not do this: the mirror handling is hilariously over engineered in the em. i kick started a patch to simplify this two week ago and my finish that anytime soon. i'm not sure about all b/w compat details yet, but it will be much shorter in the final version for master. thus, i'd rather not get a patch like that in now and only fix in 8.7 if there is really a lot of pressure to do so since the object shuffling is rather complicated currently. maybe we could just abandon this approach here? -
Christian Kuhn commented on patch set 9 03/29/18, 14:04
note that i simplified the mirror handling in language module in master already a lot. it is now one simple method that sets a registry entry within ext:install. small and straight. -
Mathias Brodala commented on patch set 9 03/29/18, 14:23
> in general, i would rather not do this: the mirror handling is > hilariously over engineered in the em. i kick started a patch to > simplify this two week ago and my finish that anytime soon. i'm not > sure about all b/w compat details yet, but it will be much shorter > in the final version for master. thus, i'd rather not get a patch > like that in now and only fix in 8.7 if there is really a lot of > pressure to do so since the object shuffling is rather complicated > currently. maybe we could just abandon this approach here? I'd be fine with any solution which avoids the mentioned issue and at least keeps the Languages module alive. -
Christian Kuhn commented on patch set 9 03/29/18, 15:21
so a straight ahead patch for 8.7 only, maybe? -
Mathias Brodala commented on patch set 9 03/29/18, 15:22
> so a straight ahead patch for 8.7 only, maybe? Fine with me. If possible after your Languages change in master to follow the usual fixing chain. -
Anja Leichsenring commented on patch set 9 04/14/18, 14:20
so how to proceed here? Abandon for master, push to 8.7? -
Mathias Brodala abandoned the change 04/17/18, 12:59
Abandoned in favor of the v8-only fix here: https://review.typo3.org/56709