Review TYPO3_8-7 Merged

54828[BUGFIX] Check simplexml return type in ImageInfo

Christian Kuhn CR +2 V +2 Easy +41 −2 updated 11/28/17, 14:29

Commit message

According to the php documentation[1] simplexml_load_file may return
false on failure. We need to check for this before we call the
attributes method on the expected SimpleXMLElement.

[1] http://php.net/manual/en/function.simplexml-load-file.php

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 611

  1. Christian Kuhn commented on patch set 1 11/28/17, 11:14

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 11/28/17, 11:29 Completed build in 14m 56s on Tue, 28 Nov, 12:29 PM Test Summary: 6 of 57983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1361

  3. TYPO3com commented on patch set 1 11/28/17, 12:14 Completed build in 1h 15m 08s on Tue, 28 Nov, 01:14 PM Test Summary: 6 of 57983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1361

  4. Markus Klein uploaded patch set 2 11/28/17, 12:22

  5. TYPO3com voted on patch set 2 V -1 11/28/17, 12:38 Completed build in 15m 33s on Tue, 28 Nov, 01:38 PM Test Summary: 6 of 57983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1362

  6. Markus Klein updated the commit message in patch set 3 11/28/17, 14:09

  7. Markus Klein uploaded patch set 4 11/28/17, 14:14

  8. TYPO3com voted on patch set 3 V -1 11/28/17, 14:23 Completed build in 14m 08s on Tue, 28 Nov, 03:23 PM Test Summary: 6 of 57983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1363

  9. TYPO3com voted on patch set 4 V +1 11/28/17, 14:28 Completed build in 14m 28s on Tue, 28 Nov, 03:28 PM Test Summary: 57623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1364

  10. Markus Klein voted on patch set 4 CR +2 V +2 11/28/17, 14:29

  11. Gerrit merged patch set 4 11/28/17, 14:29