54832[WIP][BUGFIX] Don't remove markup after adding link in ckeditor
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 1015
-
Sebastian Hofer uploaded patch set 1 11/28/17, 14:24
-
TYPO3com voted on patch set 1 V +1 11/28/17, 14:35 Completed build in 11m 30s on Tue, 28 Nov, 03:35 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16821
-
Frank Nägler updated the commit message in patch set 2 11/28/17, 14:37
-
Frank Nägler voted on patch set 2 CR +1 V +1 11/28/17, 14:38
-
Sebastian Hofer updated the commit message in patch set 3 11/28/17, 14:40
-
TYPO3com voted on patch set 3 V +1 11/28/17, 14:50 Completed build in 09m 31s on Tue, 28 Nov, 03:50 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16828
-
TYPO3com voted on patch set 2 V +1 11/28/17, 14:52 Completed build in 14m 27s on Tue, 28 Nov, 03:52 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16826
-
Riccardo De Contardi commented on patch set 3 V +1 11/28/17, 19:36
tested with latest master and both the scenarios in the issue description. -
Andreas Allacher commented on patch set 3 11/28/17, 22:02
RteLinkBrowser.js:111The indentation seems to be wrong for this line. -
Sebastian Hofer uploaded patch set 4 11/28/17, 23:05
-
TYPO3com voted on patch set 4 V +1 11/28/17, 23:14 Completed build in 08m 34s on Wed, 29 Nov, 12:14 AM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16885
-
Andreas Allacher commented on patch set 4 V -1 11/29/17, 06:54
I have now tested it and HTML inside works now. However, the edge cases I mentioned in the ticket like: creating a table and selecting two cells or creating an ordered list and selecting to list items are not working as they should. With the default link plugin the links are created per table cell / link item. With this change what happens is that in case of e.g. the two table cells that the content of one table cell is replaced with a new table that contains both table cells. In case of the list basically the same happens. As said with the original plugin this doesn't happen. I guess using editor.editable().extractHtmlFromRange( range ); like the original plugin might be the key there? -
Sebastian Hofer uploaded patch set 5 11/29/17, 16:13
-
TYPO3com voted on patch set 5 V +1 11/29/17, 16:25 Completed build in 11m 52s on Wed, 29 Nov, 05:25 PM Test Summary: 57000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16981
-
Christian Kuhn abandoned the change 09/16/18, 23:31
hey. i'll abandon this patch for the sake of a more clean review queue for now since nothing happened for about a year. please feel free to resurrect the patch to continue working on it.