Review main Merged

54835[BUGFIX] UpgradeWizard check for utf8 is wrong

Susi Moog CR +2 V +2 Easy +6 −3 updated 11/28/17, 19:14

Commit message

The upgrade wizard checking for utf-8 sets a
variable called charsetOk which worked
differently on MySQL compared to other DBMS.

On MySQL it contained true if the charset was
not OK, in all other cases it was true if ok.

This is now consistently handled according to
the variable name.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Susi Moog uploaded patch set 1 11/28/17, 16:11

  2. TYPO3com voted on patch set 1 V +1 11/28/17, 16:21 Completed build in 09m 59s on Tue, 28 Nov, 05:21 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16837

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 11/28/17, 17:28

  4. Mathias Schreiber voted on patch set 1 CR +1 V +1 11/28/17, 18:21

  5. Wouter Wolters voted on patch set 1 CR +1 11/28/17, 18:36

  6. Andreas Kienast voted on patch set 1 CR +1 11/28/17, 19:06

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 11/28/17, 19:14

  8. Gerrit merged patch set 1 11/28/17, 19:14