Review main Merged

54836[TASK] Port TYPO3.LLL usages to TYPO3.lang

Pawel Cieslik CR +2 V +2 Easy +24 −21 updated 11/29/17, 10:42

Commit message

TYPO3 core uses new JS api for fetching language labels - TYPO3.lang.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Łukasz Uznański +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Łukasz Uznański +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1113

  1. Pawel Cieslik uploaded patch set 1 11/28/17, 16:25

  2. Tymoteusz Motylewski updated the commit message in patch set 2 11/28/17, 16:28

  3. TYPO3com voted on patch set 1 V +1 11/28/17, 16:36 Completed build in 10m 17s on Tue, 28 Nov, 05:36 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16839

  4. Tymoteusz Motylewski voted on patch set 2 CR +1 11/28/17, 16:36

  5. TYPO3com voted on patch set 2 V +1 11/28/17, 16:39 Completed build in 10m 37s on Tue, 28 Nov, 05:39 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16840

  6. Benni Mack voted on patch set 2 CR +2 11/28/17, 17:12

  7. Wouter Wolters commented on patch set 2 CR -1 11/28/17, 18:33

    Same question for class FrontendEditAssetLoader. There TYPO3.LLL is also set. Small -1 to get an answer to my question.

    BackendController.php:612

    if TYPO3.LLL is not used anymore we can drop this complete method if I'm correct.
  8. Pawel Cieslik commented on patch set 2 11/28/17, 21:21

    > (1 comment) > > Same question for class FrontendEditAssetLoader. There TYPO3.LLL is > also set. Small -1 to get an answer to my question. it was left for compatibility and this is intended. it has to be removed in different TASK.
  9. Wouter Wolters commented on patch set 2 CR +1 11/28/17, 21:38

    ok thanks for the answer
  10. Tymoteusz Motylewski commented on patch set 2 V +1 11/29/17, 10:21

    tested by placing "debugger;" in js files, refreshing backend and seeing if labels are there.
  11. Łukasz Uznański commented on patch set 2 CR +1 V +1 11/29/17, 10:33

    all labels are on place
  12. Tymoteusz Motylewski voted on patch set 2 CR +2 V +2 11/29/17, 10:42

  13. Gerrit merged patch set 2 11/29/17, 10:42