Review main Merged Breaking

54837[!!!][TASK] Remove custom userfunc of DataMapper->getPlainValue

Benni Mack CR +2 V +2 Normal +46 −37 updated 12/08/17, 05:42

Commit message

DataMapper's hidden functionality of having a callback functionality
to modify a string before storing it in the database. This was used
for database abstraction with $TYPO3_DB ("fullQuoteStr"), which is now
obsolete for Extbase in general.

Thus, the code can be removed.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 79

  1. Benni Mack uploaded patch set 1 11/28/17, 17:08

  2. TYPO3com voted on patch set 1 V +1 11/28/17, 17:17 Completed build in 08m 27s on Tue, 28 Nov, 06:17 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16846

  3. Benni Mack uploaded patch set 2 12/06/17, 15:27

  4. TYPO3com voted on patch set 2 V +1 12/06/17, 15:41 Completed build in 13m 17s on Wed, 6 Dec, 04:41 PM Test Summary: 57015 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17240

  5. Susi Moog voted on patch set 2 CR +1 12/06/17, 18:25

  6. Georg Ringer voted on patch set 2 CR +1 V +1 12/07/17, 06:30

  7. Daniel Gorges voted on patch set 2 CR +1 V +1 12/08/17, 05:19

  8. Benni Mack voted on patch set 2 CR +2 V +2 12/08/17, 05:42

  9. Gerrit merged patch set 2 12/08/17, 05:42