Review main Merged

54838[TASK] Separately extract @validate annotations

Alexander Schnitzler CR +2 V +2 Normal +89 −0 updated 11/28/17, 22:07

Commit message

Separately exctracting the @validate annotations
makes resolving these annotations more testable.

Also this allows to deprecate the usage of @validate
in favor of a doctrine annotation.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Alexander Schnitzler uploaded patch set 1 11/28/17, 18:03

  2. TYPO3com voted on patch set 1 V +1 11/28/17, 18:13 Completed build in 09m 24s on Tue, 28 Nov, 07:13 PM Test Summary: 56876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16849

  3. Christian Kuhn updated the commit message in patch set 2 11/28/17, 18:23

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 11/28/17, 18:24

  5. Wouter Wolters voted on patch set 2 CR +1 11/28/17, 18:27

  6. TYPO3com voted on patch set 2 V +1 11/28/17, 18:33 Completed build in 09m 17s on Tue, 28 Nov, 07:33 PM Test Summary: 56876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16850

  7. Benni Mack voted on patch set 2 CR +2 V +2 11/28/17, 22:07

  8. Gerrit merged patch set 2 11/28/17, 22:07