Review TYPO3_7-6 Merged

54839[BUGFIX] Failing task "Fileadmin garbage collection"

Sebastian Hofer CR +2 V +2 Easy +3 −1 updated 11/28/17, 22:11

Commit message

Fix the identifier string, which is used to retrive the file object,
a relative path instead of an absolute path is expected.

Review

  • Code review CR +2
    • Benni Mack +2
    • Manuel Selbach +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Manuel Selbach +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Files 1

Review log 912

  1. Sebastian Hofer uploaded patch set 1 11/28/17, 19:35

  2. TYPO3com voted on patch set 1 V +1 11/28/17, 19:40 Completed build in 05m 21s on Tue, 28 Nov, 08:40 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1209

  3. Christian Kuhn commented on patch set 1 11/28/17, 19:50

    note this is relevant for 7.6 only since the offending patch https://review.typo3.org/#/c/50432/ was done in 7.6 only, too.
  4. Christian Kuhn updated the commit message in patch set 2 11/28/17, 19:53

  5. TYPO3com voted on patch set 2 V +1 11/28/17, 19:58 Completed build in 05m 08s on Tue, 28 Nov, 08:58 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1210

  6. Oliver Klee commented on patch set 2 11/28/17, 20:57

    obsolute = obsolete and absolute ;-)
  7. Oliver Klee updated the commit message in patch set 3 11/28/17, 20:57

  8. TYPO3com voted on patch set 3 V +1 11/28/17, 21:02 Completed build in 04m 53s on Tue, 28 Nov, 10:02 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1211

  9. Christian Kuhn commented on patch set 3 CR +1 V +1 11/28/17, 21:20

    tested and had fun with it :) ... thinking of using typo3 as backup strategy now ;)
  10. Manuel Selbach voted on patch set 3 CR +1 V +1 11/28/17, 22:05

  11. Benni Mack voted on patch set 3 CR +2 V +2 11/28/17, 22:11

  12. Gerrit merged patch set 3 11/28/17, 22:11