Review main Abandoned

54846[WIP][TASK] Add Converter for pages_language_overlay data in DataHandler

Fabian Auer CR 0 V 0 Hard +278 −0 updated 01/12/18, 22:25

Commit message

beforeStart Hook in the dataHandler to convert pages_language_overlay records like the migration scripts in install tool do.

* converts import in pages_language_overlay records to imports in pages
* converts imports in be_groups table if pages_language_overlay permission to page permissions.

Fixes Import data from impexp and can be tested with the introduction package.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 912

  1. Fabian Auer uploaded patch set 1 11/28/17, 22:18

  2. TYPO3com voted on patch set 1 V -1 11/28/17, 22:19 Completed build in 25s on Tue, 28 Nov, 11:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16881

  3. Benni Mack uploaded patch set 2 11/29/17, 14:23

  4. TYPO3com voted on patch set 2 V -1 11/29/17, 14:33 Completed build in 10m 13s on Wed, 29 Nov, 03:33 PM Test Summary: 1 of 57215 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16958

  5. Oliver Hader commented on patch set 2 CR -1 11/29/17, 15:00

    Thanks for your patch. However, I'd suggest not the register a global hook for that. Rather use Hooks in ImportExport, e.g. have a look at $this->callHook('before_writeRecordsRecords', ...) in \TYPO3\CMS\Impexp\Import
  6. Benni Mack commented on patch set 2 11/29/17, 15:04

    @Olly: NO!!! THIS ONLY SOLVES YOUR PROBLEM! If extension authors have their own APIs (we have a lot of huge projects doing programatic DataHandler logic with multi-languages) this should also work natively. This is not impexp specific at all, think of l10nmgr. I strongly urge you to reconsider your -1.
  7. Oliver Hader commented on patch set 2 CR 0 11/29/17, 19:52

    Thanks for explanation, in case of lion manager it makes sense this is handled at the global scope. Removed my -1
  8. Oliver Hader uploaded patch set 3 11/29/17, 20:48

  9. TYPO3com voted on patch set 3 V +1 11/29/17, 20:58 Completed build in 09m 43s on Wed, 29 Nov, 09:58 PM Test Summary: 57008 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17044

  10. Christian Kuhn commented on patch set 3 V -1 CR -1 01/12/18, 22:20

    hey fabian. thx for your works on this patch. However, ext:impexp is not a tool to do data migration between core upgrades. that's what the update wizards are for. we can not make ext:impexp cope with all core changes on db or relation layer to handle imports from some (major) core version into some other major core version. thus, i'd opt to abandon this patch, a transparent import of records that are includede as pages_language_overlay as records in pages (fixing all relations and stuff like that) is not the scope of ext:impexp.
  11. Christian Kuhn commented on patch set 3 01/12/18, 22:25

    i'll go ahead and will abandon this patch for now. If i'm totally off-topic or got the approach wrong, please feel free to push a new patch.
  12. Christian Kuhn abandoned the change 01/12/18, 22:25