Review main Merged

54848[BUGFIX] Ensure all sys_file_metadata TCA columns have a config section

Benni Mack CR +2 V +2 Hard +336 −306 updated 11/29/17, 13:41

Commit message

The main issue is that the core ships a TCA column without a config section.

If EXT:filemetadata is available, this is overridden, so no issue here.

Further steps are (not scope of this patch) would be a TCA migration checker
to ensure that all TCA columns have a config section.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 3

Files 12

Review log 1523

  1. Benni Mack uploaded patch set 1 11/29/17, 09:22

  2. Benni Mack updated the commit message in patch set 2 11/29/17, 09:25

  3. TYPO3com voted on patch set 1 V -1 11/29/17, 09:32 Completed build in 10m 16s on Wed, 29 Nov, 10:32 AM Test Summary: 2 of 57215 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16900

  4. TYPO3com voted on patch set 2 V -1 11/29/17, 09:35 Completed build in 09m 55s on Wed, 29 Nov, 10:35 AM Test Summary: 2 of 57215 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16901

  5. TYPO3com commented on patch set 1 11/29/17, 09:36 Completed build in 24m 33s on Wed, 29 Nov, 10:36 AM Test Summary: 2 of 57215 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16900

  6. Oliver Hader commented on patch set 2 CR -1 11/29/17, 10:09

    On it: Test assertion is wrong already in current scenario (probably wrong since 6.2)
  7. Oliver Hader uploaded patch set 3 11/29/17, 12:11

  8. Oliver Hader voted on patch set 3 CR +1 V +1 11/29/17, 12:12

  9. TYPO3com voted on patch set 3 V -1 11/29/17, 12:23 Completed build in 11m 33s on Wed, 29 Nov, 01:23 PM Test Summary: 8 of 57215 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16937

  10. TYPO3com commented on patch set 3 11/29/17, 12:41 Completed build in 41m 15s on Wed, 29 Nov, 01:41 PM Test Summary: 8 of 57215 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16937

  11. Christian Kuhn updated the commit message in patch set 4 11/29/17, 12:43

  12. Christian Kuhn commented on patch set 4 CR -1 11/29/17, 12:49

    on it.
  13. TYPO3com voted on patch set 4 V -1 11/29/17, 12:54 Completed build in 10m 39s on Wed, 29 Nov, 01:54 PM Test Summary: 8 of 57215 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16944

  14. Christian Kuhn uploaded patch set 5 11/29/17, 13:04

  15. Oliver Hader commented on patch set 4 11/29/17, 13:06

    l10n_exclude behavior is different in 7.6 - I'd suggest not to back port it to 7.6
  16. TYPO3com voted on patch set 5 V +1 11/29/17, 13:14 Completed build in 09m 59s on Wed, 29 Nov, 02:14 PM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16947

  17. Benni Mack updated the commit message in patch set 6 11/29/17, 13:22

  18. Oliver Hader voted on patch set 6 CR +1 11/29/17, 13:27

  19. TYPO3com voted on patch set 6 V +1 11/29/17, 13:34 Completed build in 11m 30s on Wed, 29 Nov, 02:34 PM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16953

  20. Oliver Hader commented on patch set 6 V +1 11/29/17, 13:37

    For the scope of this change it works. However, when uploading and overriding a different file with the same name, the dimensions of the localized sys_file_metadata records are not adjusted. However, this is a different issue and related to file indexing.
  21. Oliver Hader voted on patch set 6 CR +2 V +2 11/29/17, 13:40

  22. Gerrit merged patch set 6 11/29/17, 13:41

  23. Oliver Hader commented on patch set 7 11/29/17, 13:41

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit cbf7784c36a6b36c3c0f57c7e0c0de262f369db6