54856[BUGFIX] The CE File Links (fluid_styled_content) create thumbs for non-image files
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Jörg Bösche +1
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 810
-
Jonathan IROULIN uploaded patch set 1 11/29/17, 11:27
-
Benjamin Kott commented on patch set 1 CR -1 11/29/17, 11:38
Please make it more strict we should only allow image processing on files where we are sure that these are actually images. In that case please restrict this to FILETYPE_IMAGE = 2. Otherwise you will still try to create thumbnails for videos and audio files. -
TYPO3com voted on patch set 1 V +1 11/29/17, 11:38 Completed build in 11m 20s on Wed, 29 Nov, 12:38 PM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16924
-
Jonathan IROULIN commented on patch set 1 11/29/17, 12:19
> Please make it more strict we should only allow image processing on > files where we are sure that these are actually images. In that > case please restrict this to FILETYPE_IMAGE = 2. > > Otherwise you will still try to create thumbnails for videos and > audio files. > Please make it more strict we should only allow image processing on > files where we are sure that these are actually images. In that > case please restrict this to FILETYPE_IMAGE = 2. > > Otherwise you will still try to create thumbnails for videos and > audio files. I tried but we loose video and audio player as thumbnails. I uploaded results with my patch and your suggestion here : https://forge.typo3.org/issues/79711#note-9 Please watch them. -
Jonathan IROULIN rebased onto patch set 2 11/29/17, 17:45
-
TYPO3com voted on patch set 2 V +1 11/29/17, 18:00 Completed build in 15m 42s on Wed, 29 Nov, 07:00 PM Test Summary: 57002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17006
-
Jörg Bösche voted on patch set 2 CR +1 12/04/17, 08:40
-
Benni Mack voted on patch set 2 CR +1 V +1 12/09/17, 22:13
-
Susi Moog voted on patch set 2 CR +2 V +2 12/09/17, 22:16
-
Gerrit merged patch set 2 12/09/17, 22:16