Review main Merged

54857[TASK] All TCA columns should have a config section

Christian Kuhn CR +2 V +2 Normal +116 −62 updated 11/29/17, 18:55

Commit message

Having a TCA columns field without 'config' array doesn't make
sense. ['config']['type'] is marked as mandatory field anyway
and the TCA migration throws an exception if ['config'] exists
but ['type'] is missing for a while.
The patch now adds code to add ['config']['type'] = 'none' if
['config'] does not exist at all.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 11/29/17, 11:33

  2. Christian Kuhn commented on patch set 1 11/29/17, 11:36

    TcaMigrationTest.php:2229

    note: adding 'config' on the two superfluous data sets makes them identical to the two remove data sets, so it is ok to remove the two.
  3. TYPO3com voted on patch set 1 V -1 11/29/17, 11:43 Completed build in 09m 57s on Wed, 29 Nov, 12:43 PM Test Summary: 2 of 57209 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16926

  4. Christian Kuhn commented on patch set 1 CR -1 11/29/17, 11:51

    hrr, the unit test found a funny edge case for flex forms.
  5. Christian Kuhn uploaded patch set 2 11/29/17, 12:10

  6. TYPO3com voted on patch set 2 V +1 11/29/17, 12:20 Completed build in 10m 26s on Wed, 29 Nov, 01:20 PM Test Summary: 56850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16936

  7. Benni Mack voted on patch set 2 CR +1 V +1 11/29/17, 18:13

  8. Wouter Wolters voted on patch set 2 CR +2 V +2 11/29/17, 18:55

  9. Gerrit merged patch set 2 11/29/17, 18:55