Review main Merged Breaking

54860[!!!][TASK] Remove TYPO3.LLL usages in TYPO3 core

Pawel Cieslik CR +2 V +2 Normal +38 −185 updated 11/29/17, 16:33

Commit message

Remove TYPO3.LLL after moving to new JS API for translations TYPO3.lang

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1723

  1. Pawel Cieslik uploaded patch set 1 11/29/17, 12:06

  2. TYPO3com voted on patch set 1 V -1 11/29/17, 12:18 Completed build in 12m 02s on Wed, 29 Nov, 01:18 PM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16935

  3. Łukasz Uznański voted on patch set 1 CR +1 11/29/17, 12:28

  4. Pawel Cieslik uploaded patch set 2 11/29/17, 12:56

  5. TYPO3com voted on patch set 2 V +1 11/29/17, 13:06 Completed build in 09m 41s on Wed, 29 Nov, 02:06 PM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16945

  6. Pawel Cieslik uploaded patch set 3 11/29/17, 13:16

  7. Benni Mack updated the commit message in patch set 4 11/29/17, 13:17

  8. Benni Mack voted on patch set 4 CR +1 11/29/17, 13:24

  9. TYPO3com voted on patch set 4 V +1 11/29/17, 13:28 Completed build in 11m 00s on Wed, 29 Nov, 02:28 PM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16952

  10. TYPO3com voted on patch set 3 V +1 11/29/17, 13:28 Completed build in 11m 52s on Wed, 29 Nov, 02:28 PM Test Summary: 56856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16951

  11. Łukasz Uznański voted on patch set 4 CR +1 11/29/17, 14:59

  12. Markus Klein commented on patch set 5 11/29/17, 15:01

    Published edit on patch set 4.
  13. Markus Klein commented on patch set 5 11/29/17, 15:03

    BackendController.php:111

    are you sure about this removal?
  14. TYPO3com voted on patch set 5 V +1 11/29/17, 15:16 Completed build in 14m 27s on Wed, 29 Nov, 04:16 PM Test Summary: 56886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16968

  15. Tymoteusz Motylewski commented on patch set 5 11/29/17, 15:18

    BackendController.php:111 Reply

    it's duplicated with line 167?
  16. Markus Klein commented on patch set 5 11/29/17, 15:47

    BackendController.php:111 Reply

    No, line 167 is just for JS languages. This line will also enable usage in BE modules.
  17. Benni Mack commented on patch set 5 11/29/17, 15:52

    BackendController.php:111 Reply

    you are right we need to keep it, however, Markus, this is only for toolbar, modulemenu, but not relevant for modules.
  18. Markus Klein commented on patch set 5 11/29/17, 16:15

    Right benni
  19. Markus Klein commented on patch set 6 11/29/17, 16:16

    Published edit on patch set 5.
  20. Markus Klein voted on patch set 6 CR +1 V +1 11/29/17, 16:17

  21. TYPO3com voted on patch set 6 V +1 11/29/17, 16:31 Completed build in 15m 10s on Wed, 29 Nov, 05:31 PM Test Summary: 57000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16983

  22. Benni Mack commented on patch set 6 CR +2 V +2 11/29/17, 16:33

    BackendController.php:111 Reply

    you are right, we need to keep
  23. Gerrit merged patch set 6 11/29/17, 16:33