Review TYPO3_8-7 Merged

54875[BUGFIX] Properly handle flexform related exceptions

Christian Kuhn CR +2 V +2 Normal +74 −20 updated 11/29/17, 19:32

Commit message

The FlexFormTools class tries to resolve the datastructure
of flex fields by the given TCA configuration. The flexform
definition can either be set directly in the TCA or it is
fetched from another record.

Example:
TemplaVoilà fetches the data structure from the table
tx_templavoila_datastructure.

When trying to resolve the data structure from another
table and the identifier is invalid (e.g. empty or does
not point to a valid record), several exceptions are
thrown that need to be caught at several points to keep
the user interface accessible.

Other than these mentioned exceptions there are ones
that indicate that the TCA configuration is simply wrong.
These ones are not caught and will still bubble up.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Files 3

Review log 34

  1. Christian Kuhn commented on patch set 1 11/29/17, 19:13

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/29/17, 19:27 Completed build in 13m 50s on Wed, 29 Nov, 08:27 PM Test Summary: 57635 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1394

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 11/29/17, 19:32

  4. Gerrit merged patch set 1 11/29/17, 19:32