Review main Merged

54878[TASK] Suggest PHP "intl" extension

Markus Klein CR +2 V +2 Normal +139 −2 updated 11/30/17, 12:39

Commit message

This is the basis for further improvements, which require
locale aware operations.

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Wolf +2
    • Wouter Wolters +1
    • Mathias Brodala +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Wolf +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1619

  1. Markus Klein uploaded patch set 1 11/29/17, 21:30

  2. TYPO3com voted on patch set 1 V +1 11/29/17, 21:41 Completed build in 10m 57s on Wed, 29 Nov, 10:41 PM Test Summary: 57010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17049

  3. Mathias Brodala commented on patch set 1 CR +1 11/30/17, 08:39

    Here I was just about to post https://review.typo3.org/39801 but I see what you did there. ;-)
  4. Mathias Brodala commented on patch set 1 CR -1 11/30/17, 08:40

    I guess this must be added to TYPO3\CMS\Install\SystemEnvironment\Check too.
  5. Markus Klein uploaded patch set 2 11/30/17, 08:49

  6. Markus Klein commented on patch set 2 CR -1 11/30/17, 08:51

    need to check with benni if intl is required or optional now
  7. Markus Klein voted on patch set 2 CR 0 11/30/17, 08:55

  8. Markus Klein commented on patch set 2 11/30/17, 08:56

    ready to roll
  9. TYPO3com voted on patch set 2 V +1 11/30/17, 08:59 Completed build in 09m 36s on Thu, 30 Nov, 09:59 AM Test Summary: 57040 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17069

  10. Mathias Brodala updated the commit message in patch set 3 11/30/17, 09:23

  11. Mathias Brodala voted on patch set 3 CR +1 11/30/17, 09:24

  12. Benni Mack voted on patch set 3 CR +2 11/30/17, 09:36

  13. Wouter Wolters voted on patch set 3 CR +1 11/30/17, 10:08

  14. TYPO3com voted on patch set 3 V +1 11/30/17, 10:13 Completed build in 13m 17s on Thu, 30 Nov, 11:13 AM Test Summary: 57040 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17079

  15. Susi Moog commented on patch set 3 11/30/17, 10:35

    INSTALL.md:85

    here we add it to required PHP extensions, but it is only suggested. shouldn't we add it below where fileinfo is also mentioned as it is 'only' a suggestion?
  16. Andreas Wolf commented on patch set 3 CR +2 11/30/17, 10:37

    All good once we solved the comment on INSTALL.md.

    INSTALL.md:85 Reply

    Sounds logical to me.
  17. Andreas Wolf voted on patch set 3 V +1 11/30/17, 10:41

  18. Benni Mack voted on patch set 3 V +2 11/30/17, 12:39

  19. Gerrit merged patch set 3 11/30/17, 12:39