Review TYPO3_8-7 Merged

54892[BUGFIX] ModuleMenu::loadNavigationComponent must load custom tree

Wouter Wolters CR +2 V +2 Easy +7 −4 updated 01/12/18, 12:11

Commit message

This patch changes initialization of the pagetree to make it possible
to open a custom module with its own navigation directly without the
need to open a Web/* module after opening the backend.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Andreas Kienast +1
    • Reiner Teubner +1
  • Verified V +2
    • Christian Kuhn +2
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Wouter Wolters commented on patch set 1 11/30/17, 20:14

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/30/17, 20:28 Completed build in 13m 48s on Thu, 30 Nov, 09:28 PM Test Summary: 57677 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1410

  3. Andreas Kienast voted on patch set 1 CR +1 12/01/17, 08:40

  4. Frank Nägler commented on patch set 1 CR +1 01/11/18, 16:35

    code looks ok for me, but I can't verify the patch because I have no setup or extension to test the patch.
  5. Christian Kuhn voted on patch set 1 V +1 CR +1 01/12/18, 11:54

  6. Christian Kuhn commented on patch set 1 01/12/18, 11:55

    waiting for testing vote by reiner.
  7. Reiner Teubner voted on patch set 1 V +1 CR +1 01/12/18, 12:08

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 01/12/18, 12:11

  9. Christian Kuhn merged patch set 2 01/12/18, 12:11