Review main Merged

54893[TASK] Allow Symfony 4 as constraint for composer

Benni Mack CR +2 V +2 Easy +4 −4 updated 12/09/17, 07:58

Commit message

Symfony4 was released today, and using Symfony 4 components
should not be restricted.

The current used Symfony components (YAML, Finder, Console)
mainly concentrated on cleanup for the code.

For the bundled zip/tar.gz archives, nothing changes.

Review

  • Code review CR +2
    • Susi Moog +2
    • Stefan Neufeind +1
  • Verified V +2
    • Susi Moog +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1619

  1. Benni Mack uploaded patch set 1 11/30/17, 20:51

  2. Wouter Wolters voted on patch set 1 CR +1 11/30/17, 20:53

  3. TYPO3com voted on patch set 1 V +1 11/30/17, 21:01 Completed build in 09m 24s on Thu, 30 Nov, 10:01 PM Test Summary: 57048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17138

  4. Christian Kuhn commented on patch set 1 12/01/17, 23:06

    are we sure 4.0 versions of the three symfony components can be used with core and don't break something?
  5. Christian Kuhn commented on patch set 1 12/01/17, 23:07

    example from finder: https://github.com/symfony/finder/blob/master/CHANGELOG.md guess the two "removed" notices are ok, but did you check that, benni? what about the other two components?
  6. Benni Mack commented on patch set 1 12/06/17, 18:51

    I did check the other ones and did not find anything other "strange" things, but we cannot be sure, of course.
  7. Stefan Neufeind uploaded patch set 2 12/07/17, 08:06

  8. Stefan Neufeind commented on patch set 1 12/07/17, 08:07

    Because of a merge-conflict with composer.json I've redone this using the composer-CLI, which updated the composer.json for me as expected. The components themselves still didn't get 4.0-versions in the composer.lock. But I expect that's fine because of some dependencies.
  9. Stefan Neufeind voted on patch set 2 CR +1 V +1 12/07/17, 08:08

  10. Stefan Neufeind commented on patch set 2 12/07/17, 08:09

    just relaxed the constraints. but still we pull in 3.x-components currently, fine?
  11. TYPO3com voted on patch set 2 V +1 12/07/17, 08:17 Completed build in 10m 53s on Thu, 7 Dec, 09:17 AM Test Summary: 56991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17283

  12. Benni Mack commented on patch set 2 12/07/17, 19:27

    yes, but you updated the symfony libraries now as well.
  13. Stefan Neufeind commented on patch set 2 12/07/17, 20:33

    that was not intended? I thought you wanted to losen the constrains and in that context also "see what difference it makes" (pull in what new matches). Sorry if I did wrong. Then please push a new patch or let me know - just wanted to help (and wanted to verify the change myself, what the json-change would pull in ...).
  14. Benni Mack commented on patch set 2 12/07/17, 20:45

    no worries, if we want to update the dependencies, we can do that in a separate patch.
  15. Stefan Neufeind uploaded patch set 3 12/07/17, 21:12

  16. Stefan Neufeind commented on patch set 3 CR +1 V +1 12/07/17, 21:13

    now without dep-updates
  17. TYPO3com voted on patch set 3 V +1 12/07/17, 21:21 Completed build in 08m 57s on Thu, 7 Dec, 10:21 PM Test Summary: 57129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17374

  18. Susi Moog voted on patch set 3 CR +2 V +2 12/09/17, 07:58

  19. Gerrit merged patch set 3 12/09/17, 07:58