Review main Merged

54898[TASK] Allow to create admins as system maintainers in Install Tool

Jonathan IROULIN CR +2 V +2 Easy +40 −1 updated 12/10/17, 09:04

Commit message

This patch add a checkbox to add the new administrator as system
maintainer.

Review

  • Code review CR +2
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1321

  1. Jonathan IROULIN uploaded patch set 1 12/01/17, 15:35

  2. TYPO3com voted on patch set 1 V -1 12/01/17, 15:36 Completed build in 10s on Fri, 1 Dec, 04:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17153

  3. Jonathan IROULIN uploaded patch set 2 12/01/17, 15:39

  4. TYPO3com voted on patch set 2 V +1 12/01/17, 15:48 Completed build in 09m 23s on Fri, 1 Dec, 04:48 PM Test Summary: 57048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17154

  5. Mathias Brodala commented on patch set 2 CR -1 12/04/17, 08:19

    MaintenanceController.php:411

    Please clean this up or add [WIP] to your commit message

    MaintenanceController.php:412

    This should be named "isSystemMaintainer" to reflect the boolean content.

    MaintenanceController.php:461

    Please drop this.
  6. Jonathan IROULIN updated the commit message in patch set 3 12/04/17, 08:20

  7. TYPO3com voted on patch set 3 V -1 12/04/17, 08:20 Completed build in 06s on Mon, 4 Dec, 09:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-TL-1878

  8. TYPO3com voted on patch set 3 V +1 12/04/17, 08:30 Completed build in 09m 39s on Mon, 4 Dec, 09:30 AM Test Summary: 57084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17188

  9. Jonathan IROULIN commented on patch set 4 12/04/17, 08:54

    Published edit on patch set 3.
  10. TYPO3com voted on patch set 4 V -1 12/04/17, 08:55 Completed build in 06s on Mon, 4 Dec, 09:55 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-TL-1879

  11. TYPO3com voted on patch set 4 V +1 12/04/17, 09:04 Completed build in 09m 35s on Mon, 4 Dec, 10:04 AM Test Summary: 57084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17189

  12. Georg Ringer commented on patch set 4 12/04/17, 09:13

    MaintenanceController.php:461

    please add space after //

    MaintenanceController.php:462

    that does IMO not work on mssql, there is a method in the datahandler to get the uid in all cases

    CreateAdmin.html:62

    id not needed imo
  13. Jonathan IROULIN uploaded patch set 5 12/04/17, 16:10

  14. TYPO3com voted on patch set 5 V +1 12/04/17, 16:19 Completed build in 09m 31s on Mon, 4 Dec, 05:19 PM Test Summary: 57084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17199

  15. Jonathan IROULIN commented on patch set 4 12/04/17, 16:22

    > (3 comments) Hello Georg, Thank you for your reviews. In typo3/sysext/install/Resources/Private/Partials/Maintenance/CreateAdmin.html we need id for accessibility. I added space after //. I will keep this in mind I added comments to yours.

    MaintenanceController.php:462 Reply

    I don't know how to do. This line use Doctrine so i thought that would not be a problem. I use method on l.498 from typo3/sysext/core/Classes/Database/Connection.php This method is also used on l.637 in typo3/sysext/install/Classes/Controller/InstallerController.php I do not know how to do it then.

    CreateAdmin.html:62 Reply

    We need an id for Accessibility in order to link the label - by his "for" attribute - to the input checkbox. Source : https://www.w3.org/WAI/tutorials/forms/labels/
  16. Benni Mack updated the commit message in patch set 6 12/09/17, 22:13

  17. Benni Mack voted on patch set 6 CR +1 V +1 12/09/17, 22:13

  18. TYPO3com voted on patch set 6 V +1 12/09/17, 22:22 Completed build in 09m 49s on Sat, 9 Dec, 11:22 PM Test Summary: 57087 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17509

  19. Susi Moog voted on patch set 6 CR +2 V +2 12/09/17, 22:23

  20. Gerrit merged patch set 6 12/09/17, 22:23

  21. Björn Jacob commented on patch set 7 12/10/17, 09:04

    Some minor things. Maybe @Jonatha wants to fix it in a follow up.

    MaintenanceController.php:460

    Why newline?

    MaintenanceController.php:461

    "just"

    MaintenanceController.php:464

    "systemMaintainers"