Review main Merged

54903[BUGFIX] Implicit constant to string cast in unit test case

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 12/02/17, 01:47

Commit message

An array key is not used as string but as constant in
two ConfigurationManager test cases. PHP 7.2 is more
picky about this an throws warnings. Fix by creating
proper strings.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Christian Kuhn uploaded patch set 1 12/02/17, 01:28

  2. TYPO3com voted on patch set 1 V +1 12/02/17, 01:41 Completed build in 12m 25s on Sat, 2 Dec, 02:41 AM Test Summary: 57048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17163

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 12/02/17, 01:47

  4. Gerrit merged patch set 1 12/02/17, 01:47

  5. TYPO3com commented on patch set 1 12/02/17, 01:47 Completed build in 18m 50s on Sat, 2 Dec, 02:47 AM Test Summary: 29962 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-TL-1860