Review TYPO3_8-7 Merged

54904[BUGFIX] Implicit constant to string cast in unit test case

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 12/02/17, 01:47

Commit message

An array key is not used as string but as constant in
two ConfigurationManager test cases. PHP 7.2 is more
picky about this an throws warnings. Fix by creating
proper strings.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 12/02/17, 01:31

  2. TYPO3com voted on patch set 1 V +1 12/02/17, 01:46 Completed build in 14m 41s on Sat, 2 Dec, 02:46 AM Test Summary: 57677 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1413

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 12/02/17, 01:47

  4. Gerrit merged patch set 1 12/02/17, 01:47