Review TYPO3_7-6 Merged

54932[TASK] Consistenly update to 2.8.x branch of Symfony packages

Helmut Hummel CR +2 V +2 Normal +84 −71 updated 12/05/17, 10:19

Commit message

To ensure PHP 5.5.0 compatibility as stated in our version constraints,
we limit updating package dependencies within our shipped code
to this PHP version.

Additionally we update these packages to their latest version

Composer commands used:

composer up symfony/console symfony/finder
composer req symfony/debug:^2.7
composer req --dev symfony/stopwatch:^2.8 symfony/process:^2.8 \
  symfony/options-resolver:^2.8 symfony/filesystem:^2.8 \
  symfony/event-dispatcher:^2.8 symfony/yaml:^2.8
composer config platform.php 5.5
composer up --lock

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Nicole Hummel +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Helmut Hummel uploaded patch set 1 12/04/17, 19:46

  2. TYPO3com voted on patch set 1 V +1 12/04/17, 19:51 Completed build in 04m 53s on Mon, 4 Dec, 08:51 PM Test Summary: 49014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1252

  3. Helmut Hummel updated the commit message in patch set 2 12/04/17, 19:55

  4. Christian Kuhn commented on patch set 2 CR +1 V +1 12/04/17, 19:58

    setting 'composer config platform.php 5.5' in our composer.json prevents us from installing dependencies not compatible with 5.5.0 in the future.
  5. Wouter Wolters voted on patch set 2 CR +1 12/04/17, 20:00

  6. TYPO3com voted on patch set 2 V +1 12/04/17, 20:00 Completed build in 04m 50s on Mon, 4 Dec, 09:00 PM Test Summary: 49014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1253

  7. Nicole Hummel voted on patch set 2 CR +2 V +2 12/05/17, 10:19

  8. Gerrit merged patch set 2 12/05/17, 10:19